Add support for 128bit trace ids to zipkin thrift spans. #378
Conversation
Includes: - Updating IDL to master - Running make thrift - Add TraceIDHigh to zipkin_thrift_span Signed-off-by: Douglas Reid <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
==========================================
+ Coverage 87.29% 87.31% +0.02%
==========================================
Files 54 54
Lines 3006 3011 +5
==========================================
+ Hits 2624 2629 +5
Misses 271 271
Partials 111 111
Continue to review full report at Codecov.
|
Signed-off-by: Douglas Reid <[email protected]>
Signed-off-by: Douglas Reid <[email protected]>
douglas-reid
force-pushed
the
zipkin-128
branch
from
090c3e7 to
f182eb4
Compare
|
@yurishkuro is there any more that needs to be done here? |
|
@yurishkuro we'd love to get this fix into Istio 1.1 release. anything else you need here? |
There was a problem hiding this comment.
Sorry, been swamped with final reviews for my book.
I am ready to merge this, but I would like to roll back the version of the IDL to something before the incomplete flag was added to jaeger.thrift (I am about to revert that in jaegertracing/jaeger-idl#53).
For example, pin the idl subrepo to commit 3471ffb.
Signed-off-by: Douglas Reid <[email protected]>
Signed-off-by: Douglas Reid <[email protected]>
|
@yurishkuro no worries. I've pinned the IDL to the requested commit, rerun |
|
@yurishkuro many thanks! |
|
@yurishkuro thank you |
Includes:
3471ffbNote: I manually verified this by running a binary with these changes compiled in, as illustrated in istio/istio#11954 (comment).
Signed-off-by: Douglas Reid [email protected]
Which problem is this PR solving?
Short description of the changes