This repository has been archived by the owner on May 23, 2024. It is now read-only.
Self Referenced Span #411
Merged
Self Referenced Span #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm, pending changes in the comments |
Codecov Report
@@ Coverage Diff @@
## master #411 +/- ##
==========================================
+ Coverage 88.38% 88.42% +0.03%
==========================================
Files 55 55
Lines 3092 3102 +10
==========================================
+ Hits 2733 2743 +10
Misses 255 255
Partials 104 104
Continue to review full report at Codecov.
|
refs jaegertracing#397 Signed-off-by: Daniel Mican <[email protected]>
Signed-off-by: Daniel Mican <[email protected]>
Signed-off-by: Daniel Mican <[email protected]>
Signed-off-by: Daniel Mican <[email protected]>
Signed-off-by: Daniel Mican <[email protected]>
Signed-off-by: Daniel Mican <[email protected]>
dm03514
force-pushed
the
poc/self-referenced-span
branch
from
717e547 to
683f98e
Compare
|
@yurishkuro updated! Thank you. Are there any other test cases that I should add? |
yurishkuro
reviewed
Aug 5, 2019
yurishkuro
reviewed
Aug 5, 2019
…nces. Provides a selfRef factory method hidningn constant/implementation details Signed-off-by: Daniel Mican <[email protected]>
dm03514
force-pushed
the
poc/self-referenced-span
branch
from
23cd8e6 to
1177fa6
Compare
Signed-off-by: Daniel Mican <[email protected]>
dm03514
force-pushed
the
poc/self-referenced-span
branch
from
2216ced to
5c4a729
Compare
yurishkuro
approved these changes
Aug 6, 2019
Signed-off-by: Daniel Mican <[email protected]>
dm03514
force-pushed
the
poc/self-referenced-span
branch
from
bb1954f to
685ac15
Compare
Signed-off-by: Daniel Mican <[email protected]>
dm03514
force-pushed
the
poc/self-referenced-span
branch
from
ac42493 to
1b6f64b
Compare
Signed-off-by: Daniel Mican <[email protected]>
dm03514
force-pushed
the
poc/self-referenced-span
branch
from
d15563b to
0890a2c
Compare
|
@yurishkuro updated, thank you for all your help with this |
|
thanks 🎉 |
|
please let us know how it works out end to end |
This was referenced Feb 17, 2020
yurishkuro
added a commit
that referenced
this pull request
Feb 17, 2020
|
@dm03514 Do you think it's correct that the sampling decision is also inherited from the Self span reference? It makes it difficult to use this mechanism for people who want to provide their own trace IDs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #397
Which problem is this PR solving?
Short description of the changes
"self"SpanContext, if so, will use the passed inSpanContextfor the span instead of generating span/trace idsTODO