This repository has been archived by the owner on May 23, 2024. It is now read-only.
TraceID.String prefix with zeroes #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wire encoding of the TraceID uses zero prefixes (jaegertracing#472). The JaegerUI also uses zero prefixes (since 1.16). So it makes sense that the Stringer of the TraceID also does this. Resolves jaegertracing#532 Signed-off-by: Lukas Vogel <[email protected]>
yurishkuro
reviewed
Sep 11, 2020
| @@ -344,9 +344,9 @@ func (c *SpanContext) isDebugIDContainerOnly() bool { | |||
|
|
|||
| func (t TraceID) String() string { | |||
| if t.High == 0 { | |||
| return fmt.Sprintf("%x", t.Low) | |||
| return fmt.Sprintf("%016x", t.Low) | |||
There was a problem hiding this comment.
I would also do it in L382 for span ID
There was a problem hiding this comment.
Done.
Should I squash? Or will you do that on pre-merge?
Also test parsing back works. Signed-off-by: Lukas Vogel <[email protected]>
|
please run all the tests, there are CI failures. |
how do I run this thing locally? Signed-off-by: Lukas Vogel <[email protected]>
|
Sorry somehow couldn't get this to run locally. a go.mod would really make this easier :P |
Signed-off-by: Lukas Vogel <[email protected]>
|
Alright, seems to pass CI now. I just had to check the project out in the correct local folder, then I could get it to work locally. Thanks. |
Codecov Report
@@ Coverage Diff @@
## master #533 +/- ##
=======================================
Coverage 89.28% 89.28%
=======================================
Files 61 61
Lines 3919 3919
=======================================
Hits 3499 3499
Misses 294 294
Partials 126 126
Continue to review full report at Codecov.
|
nabowler
added a commit
to nabowler/jaeger-client-go
that referenced
this pull request
Oct 6, 2021
…gator Based on the openzipkin/b3-propagation specification, the SpanID and ParentSpanID are to be encoded as 16 lower-hex characters. jaegertracing#533 fixed this for TraceID, and fixed the SpanID.String() method, but did not update the Zipkin Propagator SpanID encoding. This fix uses SpanID.String() to ensure proper encoding of the SpanID and ParentSpandID within the Zipkin Propagator. Signed-off-by: Nathan Bowler <[email protected]>
yurishkuro
pushed a commit
that referenced
this pull request
Oct 6, 2021
Based on the openzipkin/b3-propagation specification, the SpanID and ParentSpanID are to be encoded as 16 lower-hex characters. #533 fixed this for TraceID, and fixed the SpanID.String() method, but did not update the Zipkin Propagator SpanID encoding. This fix uses SpanID.String() to ensure proper encoding of the SpanID and ParentSpandID within the Zipkin Propagator. Signed-off-by: Nathan Bowler <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wire encoding of the TraceID uses zero prefixes (#472).
The JaegerUI also uses zero prefixes (since 1.16).
So it makes sense that the Stringer of the TraceID also does this.
Resolves #532
Signed-off-by: Lukas Vogel [email protected]