This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
Warning for mismatching env variables #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevgeny Petukhov <[email protected]>
Signed-off-by: Yevgeny Petukhov <[email protected]>
yepninja
commented
Dec 22, 2018
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
==========================================
+ Coverage 98.95% 98.95% +<.01%
==========================================
Files 43 43
Lines 1718 1725 +7
Branches 335 336 +1
==========================================
+ Hits 1700 1707 +7
Misses 18 18
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Dec 22, 2018
Signed-off-by: Yevgeny Petukhov <[email protected]>
Signed-off-by: Yevgeny Petukhov <[email protected]>
yurishkuro
reviewed
Dec 22, 2018
Signed-off-by: Yevgeny Petukhov <[email protected]>
Signed-off-by: Yevgeny Petukhov <[email protected]>
Signed-off-by: Yevgeny Petukhov <[email protected]>
|
Opps. Almost there is no habit to code without eslint. |
|
coming back to my earlier question - does this PR finish the ticket #321 ? |
|
Nope. That issue is related to PR #330 |
Iuriy-Budnikov
pushed a commit
to agile-pm/jaeger-client-node
that referenced
this pull request
Sep 25, 2021
* fix: dont trace ourselves closes jaegertracing#332 Signed-off-by: Olivier Albertini <[email protected]> * fix: add mayurkale22 recommendations Signed-off-by: Olivier Albertini <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning for a minor release.