Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide client-gen generated code to be used by other Operators #920

Closed
rareddy opened this issue Feb 20, 2020 · 4 comments · Fixed by #921
Closed

Provide client-gen generated code to be used by other Operators #920

rareddy opened this issue Feb 20, 2020 · 4 comments · Fixed by #921
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rareddy
Copy link
Contributor

rareddy commented Feb 20, 2020

Working on my operator and trying to enable the support to find available Jaeger instances, I did not find readily usable go client code that Get, List etc. This code can be auto-generated using the [client-gen](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-api-machinery/generating-clientset.md) tool. Locally I did the same to generate some code, however it would be nice have available as part of the Jaeger Operator code.
@ghost ghost added the needs-triage New issues, in need of classification label Feb 20, 2020
@jpkrohling jpkrohling added enhancement New feature or request good first issue Good for newcomers and removed needs-triage New issues, in need of classification labels Feb 21, 2020
@jpkrohling
Copy link
Contributor

I think it's a great idea. Would you like to give this a try? The OpenTelemetry Operator has a similar structure as Jaeger's and I added this there some time ago. Here's what I think would be required:

Install client-gen:
https://github.com/open-telemetry/opentelemetry-operator/blob/4593927867598681b2a13d30012c15ba98b5749c/Makefile#L95-L101

Add the command to generate.sh:
https://github.com/open-telemetry/opentelemetry-operator/blob/4593927867598681b2a13d30012c15ba98b5749c/.ci/generate.sh#L43-L55

@rareddy
Copy link
Contributor Author

rareddy commented Feb 21, 2020

Yes, I will contribute a PR for this.

@rareddy
Copy link
Contributor Author

rareddy commented Feb 21, 2020

#921

rareddy added a commit to rareddy/jaeger-operator that referenced this issue Feb 24, 2020
@rareddy
jaegertracing#920: Jaeger Client generatation
4d0c813
rareddy added a commit to rareddy/jaeger-operator that referenced this issue Mar 10, 2020
@rareddy
jaegertracing#920: Adding the Jaeger client generated code through cl…
0eb0af3 
…ient-gen

Signed-off-by: Ramesh Reddy <[email protected]>
rareddy added a commit to rareddy/jaeger-operator that referenced this issue Mar 10, 2020
@rareddy
jaegertracing#920: Adding the Jaeger client generated code through cl…
a250f8c 
…ient-gen

Signed-off-by: Ramesh Reddy <[email protected]>
jpkrohling pushed a commit that referenced this issue Mar 11, 2020
@rareddy
#920: Adding the Jaeger client generated code through client-gen (#921)
d271a44 
Signed-off-by: Ramesh Reddy <[email protected]>
@jpkrohling
Copy link
Contributor

jpkrohling commented Mar 11, 2020 •
edited
Loading

Addressed by #921

@jpkrohling jpkrohling linked a pull request Mar 11, 2020 that will close this issue
#920: Adding the Jaeger client generated code through client-gen #921
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#920: Adding the Jaeger client generated code through client-gen rareddy/jaeger-operator
2 participants
@jpkrohling @rareddy