Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled service links #1161

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Disabled service links #1161

merged 1 commit into from
Aug 19, 2020

Conversation

mikelorant
Copy link
Contributor

@mikelorant mikelorant commented Aug 19, 2020

Disabled information about services being injected into pod's environment variables.

This prevents service links environmental variables from conflicting with internal Jaeger environmental variables.

Image has been verified to work as expected. For verification purposes the image is available at:
fairfaxmedia/jaeger-operator:latest

Thanks to @dackroyd for assistance in these creating this fix.

Fixes #1158
Relates to jaegertracing/jaeger#1986

@mikelorant mikelorant changed the title 🐛 Disabled service links Disabled service links Aug 19, 2020
Disabled information about services being injected into pod's environment variables.

Signed-off-by: Michael Lorant <[email protected]>
@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #1161 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1161      +/-   ##
==========================================
+ Coverage   88.27%   88.29%   +0.02%     
==========================================
  Files          89       89              
  Lines        5491     5501      +10     
==========================================
+ Hits         4847     4857      +10     
  Misses        474      474              
  Partials      170      170              
Impacted Files Coverage Δ
pkg/deployment/agent.go 96.24% <100.00%> (+0.05%) ⬆️
pkg/deployment/all_in_one.go 100.00% <100.00%> (ø)
pkg/deployment/collector.go 96.75% <100.00%> (+0.04%) ⬆️
pkg/deployment/ingester.go 96.21% <100.00%> (+0.05%) ⬆️
pkg/deployment/query.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f443e78...45805ce. Read the comment docs.

Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jpkrohling jpkrohling merged commit 2ea13b2 into jaegertracing:master Aug 19, 2020
@jpkrohling
Copy link
Contributor

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable service links to prevent environment variable conflict
2 participants