Add deploy clean target and rename es/cass to deploy-

[pavolloffay]

Signed-off-by: Pavol Loffay [email protected]

[jpkrohling]

This change is 

[pavolloffay]

This was not grepping anything.

[codecov]

Codecov Report

Merging #149 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   96.21%   96.21%           
=======================================
  Files          28       28           
  Lines        1267     1267           
=======================================
  Hits         1219     1219           
  Misses         37       37           
  Partials       11       11

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43bcee3...124a204. Read the comment docs.

[jpkrohling]

Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @pavolloffay)

---

CONTRIBUTING.adoc, line 130 at r1 (raw file):

[source,bash]
----
make deploy-es

Why this change? make es is so much easier to type than make deploy-es...

---

Makefile, line 86 at r1 (raw file):

.PHONY: es
es:
	@kubectl create -f ./test/elasticsearch.yml 2>&1 | grep -v "already exists" || true

When running make es twice, this is shown in the second time when the output isn't redirected and grep -v isn't used:

$ make es
Error from server (AlreadyExists): error when creating "./test/elasticsearch.yml": statefulsets.apps "elasticsearch" already exists
Error from server (AlreadyExists): error when creating "./test/elasticsearch.yml": services "elasticsearch" already exists
make: *** [Makefile:86: es] Error 1

With the two parts, there's no output. In pretty much all cases, I don't care about this error message, all I care is that I end up with an ES instance. In that sense, the message is distracting.

[pavolloffay]

make deploy- makes it clear that it explicit what it does. Make es looks ambiguous to me.

[pavolloffay]

I have reverted back grep part

[jpkrohling]

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @pavolloffay)

a discussion (no related file):
I welcome the clean target, but I don't think we need new names for the other ones. If we see people being confused about what the es/cassandra/ingress targets do, we can then consider adding a deploy- prefix. Otherwise, let's keep the simpler version.

---

[pavolloffay]

. If we see people being confused about what the es/cassandra/ingress targets do, we can then consider adding a deploy- prefix. Otherwise, let's keep the simpler version.

I was the first one confused by these targets. I thought you compile Cassandra here!@ 😨

[pavolloffay]

updated to your preference

[jpkrohling]

Reviewed 2 of 3 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved