Enable dependencies and index cleaner by default

[pavolloffay]

Signed-off-by: Pavol Loffay [email protected]

[jpkrohling]

This change is 

[codecov]

Codecov Report

Merging #162 into master will increase coverage by 0.02%.
The diff coverage is 95%.

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
+ Coverage   96.36%   96.38%   +0.02%     
==========================================
  Files          30       30              
  Lines        1430     1438       +8     
==========================================
+ Hits         1378     1386       +8     
  Misses         40       40              
  Partials       12       12

Impacted Files	Coverage Δ
pkg/storage/cassandra_dependencies.go	100% <ø> (ø)	⬆️
pkg/apis/io/v1alpha1/jaeger_types.go	100% <ø> (ø)	⬆️
pkg/cronjob/spark_dependencies.go	97.46% <0%> (ø)	⬆️
pkg/strategy/controller.go	100% <100%> (ø)	⬆️
pkg/strategy/production.go	100% <100%> (ø)	⬆️
pkg/cronjob/es_index_cleaner.go	96% <100%> (ø)	⬆️
pkg/strategy/all-in-one.go	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3b8455...1444a77. Read the comment docs.

[jpkrohling]

Reviewed 11 of 11 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @pavolloffay and @objectiser)

---

pkg/strategy/controller.go, line 113 at r2 (raw file):

func normalizeIndexCleaner(spec *v1alpha1.JaegerEsIndexCleanerSpec, storage string) {
	// auto enable only for supported storages
	if storage == "elasticsearch" && spec.Enabled == nil {

We usually compare with strings.ToLower, so that Elasticsearch would be a match as well. You know, "be lenient with what you receive" :-)

---

pkg/strategy/controller_test.go, line 174 at r2 (raw file):

	defer viper.Reset()
	trueVar := true
	falseVar := false

Why can't Go provide a more elegant way to do this...

[pavolloffay]

@jpkrohling updated

[jpkrohling]

Reviewed 3 of 3 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @objectiser)