Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add managed by metric #1831

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Conversation

rubenvp8510
Copy link
Collaborator

Signed-off-by: Ruben Vargas [email protected]

Which problem is this PR solving?

  • This PR adds a metric that reports which instances are managed by other tools, like maistra/istio.

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #1831 (613247a) into main (6d5362f) will decrease coverage by 0.01%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##             main    #1831      +/-   ##
==========================================
- Coverage   88.19%   88.18%   -0.02%     
==========================================
  Files         101      101              
  Lines        6142     6153      +11     
==========================================
+ Hits         5417     5426       +9     
- Misses        543      544       +1     
- Partials      182      183       +1     
Impacted Files Coverage Δ
pkg/metrics/instances.go 88.57% <81.81%> (-0.80%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f904949...613247a. Read the comment docs.

@rubenvp8510 rubenvp8510 requested a review from pavolloffay March 29, 2022 04:18
@pavolloffay
Copy link
Member

Did you try if maistra operator sets the managed-by?

@rubenvp8510
Copy link
Collaborator Author

Did you try if maistra operator sets the managed-by?

Yes I did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants