-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add help page #120
Add help page #120
Conversation
Signed-off-by: Joe Farro <[email protected]>
how is this help page going to be invoked? I don't think we want to start keeping real documentation in the UI project, that's what readthedocs is for. For the key bindings I was thinking some help button in the Trace View that shows a popup - markdown might be an overkill for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, outside the scope of condoned approaches is inline webpack loader configuration:
I'm a bit impartial of getting into the webpack internals through CRA. I think it might be better to wait and see what they do with static assets like markdown.
Personally, I don't think its too crazy to fetch the help file when requested (think of it as code splitting which reduces the bundle size anyways). Some alternatives would be using a JS file and export markdown directly.
src/components/Help/help.md
Outdated
This document is a work in progress. To request additional documentation of the Jaeger UI, please create a [documentation ticket](https://github.com/jaegertracing/jaeger-ui/issues/new?labels=documentation). | ||
|
||
|
||
## Keyboard Shortcuts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should go in a modal for the Trace page, since its specific to that. A little tooltip can open it up
I prefer the help button and the page, but a modal sounds fine. @saminzadeh, @yurishkuro - any suggestions on what invokes the modal? To answer your question, @yurishkuro, I added a "Help" button to the top menu (which I'll now take out). |
Great. I was thinking something similar, but with the consensus approach being so far removed from my initial approach, seemed prudent to invite input, preemptively. |
Signed-off-by: Joe Farro <[email protected]>
Signed-off-by: Joe Farro <[email protected]>
Signed-off-by: Joe Farro <[email protected]>
Signed-off-by: Joe Farro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, the screenshot looks great
* Add help page Signed-off-by: Joe Farro <[email protected]> * Revert adding help as a separate page Signed-off-by: Joe Farro <[email protected]> * Trace detail keyboard shortcuts help as a modal Signed-off-by: Joe Farro <[email protected]> * Misc typo Signed-off-by: Joe Farro <[email protected]> * Misc cleanup Signed-off-by: Joe Farro <[email protected]> Signed-off-by: vvvprabhakar <[email protected]>
Per feedback on this PR, help for the keyboard shortcuts is added via a modal triggered from a
⌘
button.Edit — Info below this header is outdated
Add help documentation to the UI.
Currently, it has a few links and covers the keyboard shortcuts for the trace timeline.
One of the issues I ran into with this change was loading markdown files. It's not well supported in create-react-app. The recommended approach is to fetch the markdown at runtime and parse it in the browser (which is absurd):
However, outside the scope of condoned approaches is inline webpack loader configuration:
facebook/create-react-app#1944 (comment)
Inline webpack loader configuration is considered "not permitted" in create-react-app.
But, it gets the job done and can be changed to some other approach, in the future, if that becomes necessary.
IMO, even with these trade-offs, it is still preferable to use markdown over regular HTML for docs.
Definitely open to feedback on this approach.