Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Zipkin model to OTEL contrib #6409

Open
3 tasks
yurishkuro opened this issue Dec 25, 2024 · 2 comments
Open
3 tasks

Migrate Zipkin model to OTEL contrib #6409

yurishkuro opened this issue Dec 25, 2024 · 2 comments
Labels
area/otel good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

Part of #6408

opentelemetry-collector-contrib repo has a shared module pkg/translator/zipkin/ which currently imports these Jaeger sub-modules (among others like model):

  • github.com/jaegertracing/jaeger/model/converter/thrift/zipkin
  • github.com/jaegertracing/jaeger/thrift-gen/zipkincore

The proposal is to move both of these modules to OTEL/contrib.

  • Analyze and list which functions are used by Jaeger from these modules, e.g. by following rg 'jaegertracing.*zipkin' (rg=ringrep)
  • implement thrift-gen/zipkincore in OTEL/contrib/pkg/translator/zipkin/
  • move model/converter/thrift/zipkin code to OTEL/contrib and update Jaeger code to reference that module instead of internal
    • This should be done as two related PRs to OTEL/contrib and Jaeger where Jaeger's go.mod should point to a temporary branch of OTEL/contrib to ensure that nothing in Jaeger is broken
@yurishkuro yurishkuro added good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement labels Dec 25, 2024
@dosubot dosubot bot added the area/otel label Dec 25, 2024
@won-js
Copy link
Contributor

won-js commented Dec 30, 2024

@yurishkuro
Hello, may I try to work on this issue?

@yurishkuro
Copy link
Member Author

feel free to pick it up

@won-js won-js mentioned this issue Jan 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/otel good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yurishkuro @won-js