[chore][translator/zipkin] Remove dependency on jaeger/thrift-gen/zipkincore #37015
+2,068
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
won-js
force-pushed
the
implement-jaeger-thrift-gen
branch
from
16d41ad to
962ece0
Compare
won-js
changed the title
won-js
force-pushed
the
implement-jaeger-thrift-gen
branch
from
df61362 to
7641050
Compare
yurishkuro
reviewed
Jan 3, 2025
There was a problem hiding this comment.
Please do not take dependency on jaeger-idl repository as submodule. If you only need zipkincore.thrift, just copy it here, because it's not the golden source in jaeger-idl either.
It is difficult to evaluate the usefulness of this PR if you don't actually use the generated code. Can you incorporate it into the translators, so that the dependency is removed?
won-js
force-pushed
the
implement-jaeger-thrift-gen
branch
from
7641050 to
7ec077e
Compare
Signed-off-by: won-js <[email protected]>
won-js
requested review from
MovieStoreGuy,
andrzej-stencel,
crobert-1 and
dmitryax
as code owners
github-actions
bot
added
pkg/translator/zipkin
receiver/kafka
receiver/pulsar
receiver/zipkin
won-js
changed the title
yurishkuro
reviewed
Jan 4, 2025
yurishkuro
reviewed
Jan 4, 2025
yurishkuro
changed the title
|
I still see one use of jaeger module: |
|
please check linter failures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
implement thrift-gen/zipkincore in OTEL contrib
Migate Zipkin model to OTEL contrib in jaeger - jaegertracing/jaeger#6409