Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fake bump to instruments to report metrics in V2 scope #5817

Closed
wants to merge 19 commits into from

Conversation

Wise-Wizard
Copy link
Contributor

Which problem is this PR solving?

This PR addresses a part of the issue #5633

Description of the changes
This is a PR to achieve Observability Parity in metrics between V1 and V2 components by configuring OTEL Collector to emit desired metrics.
How was this change tested?

The changes were tested by running the following command:

make test
CI actions and compare.py script

Checklist

  • I have read CONTRIBUTING_GUIDELINES.md
  • I have signed all commits
  • I have added unit tests for the new functionality
  • I have run lint and test steps successfully
    • for jaeger: make lint test
    • for jaeger-ui: yarn lint and yarn test

@Wise-Wizard Wise-Wizard requested a review from a team as a code owner August 8, 2024 06:43
@Wise-Wizard Wise-Wizard requested a review from yurishkuro August 8, 2024 06:43
Signed-off-by: Wise-Wizard <[email protected]>
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.65%. Comparing base (eaacbf0) to head (1b86263).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5817   +/-   ##
=======================================
  Coverage   96.65%   96.65%           
=======================================
  Files         342      342           
  Lines       16525    16528    +3     
=======================================
+ Hits        15972    15975    +3     
  Misses        363      363           
  Partials      190      190           
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.81% <0.00%> (-0.01%) ⬇️
cassandra-3.x-v1 16.61% <ø> (ø)
cassandra-3.x-v2 1.74% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v1 16.61% <ø> (ø)
cassandra-4.x-v2 1.74% <0.00%> (-0.01%) ⬇️
elasticsearch-6.x-v1 18.77% <ø> (ø)
elasticsearch-7.x-v1 18.83% <ø> (-0.02%) ⬇️
elasticsearch-8.x-v1 19.02% <ø> (-0.02%) ⬇️
elasticsearch-8.x-v2 1.81% <0.00%> (-0.01%) ⬇️
grpc_v1 9.52% <ø> (+0.01%) ⬆️
grpc_v2 7.14% <0.00%> (-0.01%) ⬇️
kafka-v1 9.74% <ø> (ø)
kafka-v2 1.81% <0.00%> (-0.01%) ⬇️
memory_v2 1.81% <0.00%> (+0.01%) ⬆️
opensearch-1.x-v1 18.89% <ø> (+0.01%) ⬆️
opensearch-2.x-v1 18.88% <ø> (ø)
opensearch-2.x-v2 1.80% <0.00%> (-0.01%) ⬇️
unittests 95.08% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Wise-Wizard <[email protected]>
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we actually need to merge this, you can just use this during your analysis.

@Wise-Wizard
Copy link
Contributor Author

I don't think we actually need to merge this, you can just use this during your analysis.

Ok, so what needs to be done next then. Because, I think apart from some of the jaeger_collector metrics satisfactory parity is obtained?

@yurishkuro
Copy link
Member

You could use this change to generate the comparison documents.

@Wise-Wizard
Copy link
Contributor Author

Wise-Wizard commented Aug 8, 2024

You could use this change to generate the comparison documents.

Noted, but like I mentioned in the doc that I was hoping to address the formal user migration guide later on.
My primary focus was to achieve satisfactory parity in metrics and get it approved from you and then move on to tackling healthchecks.

@Wise-Wizard Wise-Wizard closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants