Skip to content
This repository has been archived by the owner on Jul 10, 2020. It is now read-only.

Fix for #30 #31

Merged
merged 2 commits into from
Mar 31, 2018
Merged

Fix for #30 #31

merged 2 commits into from
Mar 31, 2018

Conversation

leinardi
Copy link
Contributor

Description

Fix for #30 Attribute fabSize ignored: the TitleFABs are always mini.

Motivation

Check #30 for detail.

@jahirfiquitiva
Copy link
Owner

Thanks for the contribution. I forced the TitleFABs to be of size mini to keep consistency and difference between the MenuFAB and TitleFABs

@jahirfiquitiva
Copy link
Owner

I'll keep this one. If there's a good amount of people wanting this to be merged/included, then I will 🙂

@leinardi
Copy link
Contributor Author

leinardi commented Mar 23, 2018

I see, can I suggest than to update the README.md and the sources to reflect this choice? Currently it seems that you can change the size since the gif animation, the How to implement sections and the sample app show the use of this feature.

PS
I rebased to solve the merge conflicts.

@leinardi leinardi closed this Mar 23, 2018
@leinardi leinardi reopened this Mar 23, 2018
@jahirfiquitiva
Copy link
Owner

@leinardi
Thanks for the suggestion. I will update it soon 🙂

@hannesa2
Copy link

@jahirfiquitiva why waiting? Please don't hesitate and merge it.
Thank you

Repository owner deleted a comment from hannesaa2 Mar 23, 2018
@jahirfiquitiva jahirfiquitiva merged commit 82dde5d into jahirfiquitiva:master Mar 31, 2018
@jahirfiquitiva
Copy link
Owner

@leinardi
I've merged this, but could you please help me updating the README to match your changes (if you consider it's needed)

Thanks in advance and thanks for your contributions 😄

@leinardi
Copy link
Contributor Author

Hi @jahirfiquitiva, there is no need to update the README because this PR was just fixing a bug so there is no change in the behavior of the library: now is actually doing what is written in the README :).

@jahirfiquitiva
Copy link
Owner

@leinardi
Awesome .. Thanks for all the help 😊

@lock
Copy link

lock bot commented Apr 7, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Apr 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants