Add support for Android 15 #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for opening your first PR here 😃. Please be sure to check the contribution guidelines! 😉 |
jahirfiquitiva
requested changes
Dec 30, 2024
| return Bitmap.createBitmap(newBitmap, minX, minY, maxX - minX + 1, maxY - minY + 1) | ||
| newBitmap?.setPixels(pixels, 0, width, 0, 0, width, height) | ||
| return newBitmap?.let { Bitmap.createBitmap(it, minX, minY, maxX - minX + 1, maxY - minY + 1) } ?: bitmap.also { | ||
| Log.e("clearBitmap", "newBitmap is null") |
| @@ -4,7 +4,6 @@ import com.github.javiersantos.piracychecker.PiracyChecker | |||
| import dev.jahir.kuper.ui.activities.KuperActivity | |||
|
|
|||
| class MainActivity : KuperActivity() { | |||
|
|
|||
There was a problem hiding this comment.
please revert this change
There was a problem hiding this comment.
Now, there are no changes in MainActivity. Sorry for the mistake 😅
-- we can't create a bitmap which is nullable now if the bitmap is present it will it will clear it otherwise it will return the actual bitmap.
-- Due to my limited knowledge about Views or XML layouts, I'm not able to fix the overlapping content with status bar in Android 15. Rather I have, opted out from the enforcement. For now it is fine but Google will soon make it deprecated, so we need to adapt the layout for Android 15 before it deprecate. It is because Android 15 by-default enables edge to edge view.
jahirfiquitiva
approved these changes
Jan 2, 2025
|
thanks for the help @bhaskar966 |
|
Congrats on merging your first pull request here! 🎉 How awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added support for Android 15 and found a small bug in a function named "clearBitmap" so I fixed that.
To make the app useable and buildable I needed to update the AGP version as well as opt-out from edge to edge view.
Regarding edge-to-edge, I prefer that you or someone who knows about XML layouts adapt the design according to the guidelines of Andordi 15.
Motivation
I wanted my own apps to support Android 15, so updated here too.