Skip to content

Commit

Permalink
Add local maximum to POI widget. Fix POI export. Disable load new POI
Browse files Browse the repository at this point in the history
for now. Fix TODO. Bump version.
  • Loading branch information
jaj42 committed May 28, 2020
1 parent f892db1 commit f41353e
Show file tree
Hide file tree
Showing 5 changed files with 29 additions and 15 deletions.
8 changes: 0 additions & 8 deletions graphysio/mainui.py
Original file line number Diff line number Diff line change
Expand Up @@ -114,14 +114,6 @@ def tabChanged(self, tabid):
for title, item in submenu.items():
menu.addAction(title, item)

def readData(self, func, title='Load Data'):
future = self.executor.submit(readdata.read_file)
future.add_done_callback(self.createNewPlotWithData)
reader = readdata.ReadFile(title)
data = reader.getdata()
if data:
func(data)

def launchNewPlot(self):
reader = readdata.FileReader()
reader.askFile(self.dircache)
Expand Down
19 changes: 13 additions & 6 deletions graphysio/plotwidgets/poiselector.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
class FixIndex(Enum):
disabled = 'Disabled'
minimum = 'Local Minimum'
maximum = 'Local Maximum'
sndderiv = '2nd derivative peak'


Expand All @@ -38,12 +39,12 @@ def __init__(self, series, parent):
@property
def menu(self):
m = {
'Plot': {
'&Import POIs': partial(
self.parent.launchReadData, cb=self.poiselectorwidget.loadPOI
)
},
'Export': {'&POI to CSV': self.poiselectorwidget.exporter.poitocsv},
#'Plot': {
# '&Import POIs': partial(
# self.parent.launchReadData, cb=self.poiselectorwidget.loadPOI
# )
#},
'Export': {'&POI to CSV': self.poiselectorwidget.exporter.poi},
}
return m

Expand Down Expand Up @@ -108,6 +109,12 @@ def fixpos(self, pos):
posprop = findPOIGreedy(s, pos, 'min')
fixedposloc = s.index.get_loc(posprop, method='nearest')
correctedpos = s.index[fixedposloc]
elif self.fixvalue is FixIndex.maximum:
xmin, xmax = self.vbrange
s = self.curve.series.loc[xmin:xmax]
posprop = findPOIGreedy(s, pos, 'max')
fixedposloc = s.index.get_loc(posprop, method='nearest')
correctedpos = s.index[fixedposloc]
elif self.fixvalue is FixIndex.sndderiv:
xmin, xmax = self.vbrange
s = self.sndderiv.loc[xmin:xmax]
Expand Down
5 changes: 5 additions & 0 deletions graphysio/ui/poiwidget.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ def setupUi(self, POISelectorWidget):
self.radioFixMinimum.setObjectName("radioFixMinimum")
self.buttonGroup.addButton(self.radioFixMinimum)
self.verticalLayout.addWidget(self.radioFixMinimum)
self.radioFixMaximum = QtWidgets.QRadioButton(self.groupBox)
self.radioFixMaximum.setObjectName("radioFixMaximum")
self.buttonGroup.addButton(self.radioFixMaximum)
self.verticalLayout.addWidget(self.radioFixMaximum)
self.radioFixSecondDerivative = QtWidgets.QRadioButton(self.groupBox)
self.radioFixSecondDerivative.setObjectName("radioFixSecondDerivative")
self.buttonGroup.addButton(self.radioFixSecondDerivative)
Expand All @@ -54,4 +58,5 @@ def retranslateUi(self, POISelectorWidget):
self.groupBox.setTitle(_translate("POISelectorWidget", "Fix Position"))
self.radioFixDisabled.setText(_translate("POISelectorWidget", "Disabled"))
self.radioFixMinimum.setText(_translate("POISelectorWidget", "Local Minimum"))
self.radioFixMaximum.setText(_translate("POISelectorWidget", "Local Maximum"))
self.radioFixSecondDerivative.setText(_translate("POISelectorWidget", "2nd derivative peak"))
10 changes: 10 additions & 0 deletions graphysio/ui/poiwidget.ui
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,16 @@
</attribute>
</widget>
</item>
<item>
<widget class="QRadioButton" name="radioFixMaximum">
<property name="text">
<string>Local Maximum</string>
</property>
<attribute name="buttonGroup">
<string notr="true">buttonGroup</string>
</attribute>
</widget>
</item>
<item>
<widget class="QRadioButton" name="radioFixSecondDerivative">
<property name="text">
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[metadata]
name = graphysio
version = 2020.05.22
version = 2020.05.28
author = Jona Joachim
author-email = [email protected]
home-page = https://github.com/jaj42/graphysio
Expand Down

0 comments on commit f41353e

Please sign in to comment.