-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TCK Challenge: NamespacedView tests are dependent on non-spec h:head id attribute #1754
Comments
HTML5 allows id on head and body.
Ay. Bad. TCK should indeed be altered for the time being. |
@arjantijms any objection to accepting this one? |
Just accepted it, and we should indeed update the TCK next. |
@arjantijms @BalusC The |
reopened @arjantijms @BalusC see Brian's comment above. |
Fixed now in #1766 |
Challenged Tests:
ee.jakarta.tck.faces.test.javaee8.namespacedView.Spec790WithNamespacedViewIT#testSpec790WithNamespacedView
ee.jakarta.tck.faces.test.javaee8.namespacedView.Spec790WithNamespacedViewIT#testSpec790WithNamespacedViewAjaxNavigation
TCK Version:
Jakarta Faces 4.0.x
Tested Implementation:
Open Liberty -- containing MyFaces 4.0
Description:
Both challenged tests require determining the id prefix used in conjunction with the NamingContainer, but the test implementation is currently deriving it from the head's id:
Unfortunately, this is not an attribute required by the specification -- the Faces 4.0 VDL for h:head makes no mention of it. Mojarra has implemented this attribute for a long time, but MyFaces does not use it so these tests fail for us.
Interestingly, this attribute does appear for the first time in the JSF 2.2 VDL for h:head, but vanishes in version 2.3 and onward. It is unclear if that was an intentional exclusion or if it has somehow managed to fall out of the spec accidentally. Regardless, it is not documented in the current version and hasn't been in more than 5 years, so should not be utilized in the TCK. An alternative method to derive the prefix should be used instead.
The text was updated successfully, but these errors were encountered: