Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCK Challenge: NamespacedView tests are dependent on non-spec h:head id attribute #1754

Closed
brideck opened this issue Dec 6, 2022 · 6 comments · Fixed by #1763
Closed

TCK Challenge: NamespacedView tests are dependent on non-spec h:head id attribute #1754

brideck opened this issue Dec 6, 2022 · 6 comments · Fixed by #1763
Labels
accepted Accepted certification request challenge TCK challenge

Comments

@brideck
Copy link
Contributor

brideck commented Dec 6, 2022

Challenged Tests:
ee.jakarta.tck.faces.test.javaee8.namespacedView.Spec790WithNamespacedViewIT#testSpec790WithNamespacedView
ee.jakarta.tck.faces.test.javaee8.namespacedView.Spec790WithNamespacedViewIT#testSpec790WithNamespacedViewAjaxNavigation

TCK Version:
Jakarta Faces 4.0.x

Tested Implementation:
Open Liberty -- containing MyFaces 4.0

Description:
Both challenged tests require determining the id prefix used in conjunction with the NamingContainer, but the test implementation is currently deriving it from the head's id:

String namingContainerPrefix = page.getHead().getId().split("(?<=:)", 2)[0];

Unfortunately, this is not an attribute required by the specification -- the Faces 4.0 VDL for h:head makes no mention of it. Mojarra has implemented this attribute for a long time, but MyFaces does not use it so these tests fail for us.

Interestingly, this attribute does appear for the first time in the JSF 2.2 VDL for h:head, but vanishes in version 2.3 and onward. It is unclear if that was an intentional exclusion or if it has somehow managed to fall out of the spec accidentally. Regardless, it is not documented in the current version and hasn't been in more than 5 years, so should not be utilized in the TCK. An alternative method to derive the prefix should be used instead.

@BalusC
Copy link
Member

BalusC commented Dec 9, 2022

HTML5 allows id on head and body.

but vanishes in version 2.3 and onward

Ay. Bad.

TCK should indeed be altered for the time being.

@pnicolucci
Copy link
Contributor

@arjantijms any objection to accepting this one?

@arjantijms arjantijms added the accepted Accepted certification request label Dec 9, 2022
@arjantijms
Copy link
Contributor

any objection to accepting this one?

Just accepted it, and we should indeed update the TCK next.

@brideck
Copy link
Contributor Author

brideck commented Dec 12, 2022

@arjantijms @BalusC The page.getHead() call on line 78 of the test class was missed in the attached PR.

@pnicolucci pnicolucci reopened this Dec 13, 2022
@pnicolucci
Copy link
Contributor

reopened @arjantijms @BalusC see Brian's comment above.

@arjantijms
Copy link
Contributor

reopened @arjantijms @BalusC see Brian's comment above.

Fixed now in #1766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Accepted certification request challenge TCK challenge
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants