Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Faces TCK tests from Jakartaee-TCK platform repo #1649

Merged
merged 4 commits into from
Apr 12, 2022

Conversation

alwin-joseph
Copy link
Contributor

@alwin-joseph alwin-joseph commented Apr 3, 2022

  • The faces tck(old tck) from jakartaee-tck repository is moved to folder tck/faces-tck.
  • The tck/faces-tck build+run script from the repo : tck/faces-tck/pom.xml. The tck bundle sources will be available at release/JSF_BUILD/latest/faces-tck after the build.
  • The faces-tck will be added to the final tck bundle using tck/pom.xml. Final TCK bundle will be generated at tck/target/.
  • The tck/faces-tck run script withing the final bundle : jakarta-faces-tck/faces-tck/pom.xml (This is same as faces-tck/pom-bunlde.xml in the repo)
    (Use mvn clean verify for running the tests)

As recommended at #1600 (comment) .

@arjantijms @scottmarlow @BalusC

@scottmarlow
Copy link

CC @m0mus

@scottmarlow
Copy link

The Faces tests currently in the Platform TCK import SPEC API classes from jakarta.el, jakarta.inject, jakarta.servlet, jakarta.servlet.jsp that we are copying over to the Faces SPEC API project. I'm mentioning the referenced SPEC APIs since there is no vehicle.properties in https://github.com/eclipse-ee4j/jakartaee-tck/tree/master/install/jsf/other which is how we usually describe the Platform TCK test vehicles.

It appears that all of the tests require a compatible Servlet container which isn't surprising since this is testing the Faces technology.

The https://jakarta.ee/specifications/platform/9.1/jakarta-platform-spec-9.1.html#server-faces-3-0-requirements states:

In a full Jakarta EE product, all Jakarta EE web containers are required to support applications that use the Jakarta Server Faces technology.

@alwin-joseph
Copy link
Contributor Author

@arjantijms @BalusC It would be great if this PR can be reviewed and merged sooner so future test fixes can be made in this repo instead of jakartaee-tck.

@arjantijms
Copy link
Contributor

@alwin-joseph I was hoping me or someone else from the team could have done a more thorough review, but it seems there wasn't much time available from anyone.

I just looked over it a little, and will merge it. If there's anything non-optimal we can fix it later then.

cc @BalusC @tandraschko

@arjantijms arjantijms added this to the 4.0 milestone Apr 12, 2022
@arjantijms arjantijms added 4.0 TCK Any issue having to do with the TCK not the API of SPEC text labels Apr 12, 2022
@arjantijms arjantijms merged commit 7a6d5ad into jakartaee:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TCK Any issue having to do with the TCK not the API of SPEC text
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants