Fix old tck build, use httpclient jar from jakartaee-tck #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran into this issue as well when I ran the Update: Tested locally, and it looks good! Thanks again for fixing this. |
dmatej
reviewed
Apr 22, 2022
| @@ -123,6 +123,10 @@ | |||
| </goals> | |||
| <configuration> | |||
| <executable>docker/build_oldtck.sh</executable> | |||
| <arguments> | |||
| <argument>${maven.multiModuleProjectDirectory}</argument> | |||
There was a problem hiding this comment.
Note that this property is set just in the mvn shell script and it is discouraged to use it - it may be removed in future versions.
There was a problem hiding this comment.
True, maybe handle this in a new PR?
arjantijms
added
the
TCK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable the old tck build and run locally and from Jenkins also.
Issue : Apparently the
mvn clean verifyfrom tck/faces-tck was broken.httpclient-4.5.5.jar is copied from jakartaee-tck project and added to the bundle.
Issue : It seems an older version of the jar was getting copied when the dependencies were resolved. This was causing test failures with below exception :
[exec] [javatest.batch] 04-22-2022 13:00:58: ERROR: java.lang.IllegalArgumentException: Cannot locate declared field class org.apache.http.impl.client.HttpClientBuilder.sslcontext@arjantijms @volosied