Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test assertions should not reference mojarra.ab #1726

Merged
merged 6 commits into from
Nov 15, 2022
Merged

Fix test assertions should not reference mojarra.ab #1726

merged 6 commits into from
Nov 15, 2022

Conversation

BalusC
Copy link
Member

@BalusC BalusC commented Nov 15, 2022 •
edited by arjantijms
Loading

Fixes #1702

@BalusC
#1702 Remove assertions on
4d5d5fc 
rendered markup; assertions on behavior were sufficient
@BalusC
#1702 Remove assertions on
a3c5613 
rendered markup; assertions on behavior were sufficient
@BalusC
#1702 check parsed element and
59ae4c5 
attribute instead of rendered output
@BalusC
#1702 check parsed element and
069d2c9 
attribute instead of rendered output
@arjantijms arjantijms added this to the 4.0.1-TCK milestone Nov 15, 2022
@arjantijms arjantijms assigned arjantijms and BalusC and unassigned arjantijms Nov 15, 2022
@arjantijms arjantijms requested a review from brideck November 15, 2022 20:14
@arjantijms arjantijms changed the title Faces issue 1702 Fix test assertions should not reference mojarra.ab Nov 15, 2022
brideck
brideck approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@brideck brideck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good. We still have some failures in the updated tests, but those are either bugs to fix or separate challenges based on something other than "mojarra.ab" assertions.

@arjantijms arjantijms merged commit 916ec0b into master Nov 15, 2022
@arjantijms arjantijms deleted the faces_issue_1702 branch November 15, 2022 22:09
@arjantijms arjantijms modified the milestones: 4.0.1-TCK, 4.0.2-TCK Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brideck brideck brideck approved these changes

Assignees

@BalusC BalusC

Labels
None yet
Projects
None yet
Milestone
4.0.2-TCK
Development

Successfully merging this pull request may close these issues.

TCK Challenge: Test assertions should not reference mojarra.ab
3 participants
@BalusC @brideck @arjantijms