Faces issue 1701 #1727
Merged
Faces issue 1701 #1727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust Spec1296IT to use custom response writer
Deactivate Issue3787IT for now because this requires a new API method
arjantijms
added
the
TCK
brideck
reviewed
Nov 15, 2022
| import java.io.Writer; | ||
|
|
||
| import com.sun.faces.util.HtmlUtils; | ||
| import com.sun.faces.util.MessageUtils; |
There was a problem hiding this comment.
The TCK can't depend on com.sun.faces.util classes here. Compilation fails for us.
There was a problem hiding this comment.
Right. Mistook them to be part of TCK utils.
There was a problem hiding this comment.
I've removed the unexpected Mojarra dependency altogether to prevent future mistakes like this and copied the HtmlUtils.
Remove Mojarra dependency from TCK.
Copy HtmlUtils from Mojarra and ditch MessageUtils
brideck
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1701