Update Faces 2.3 Bean Validation Application to Address Challenge 1715

[volosied]

fixes issue reported in #1715

[volosied]

Please hold off merging. I tested this a while back, but would like to verify again.

Edit: All good. Manual tests show it works as intended (error message when passwords don't match - for both Issue4313 & Issue4083) on Mojarra 4.0.0 and MyFaces' latest snapshot.

[volosied]

MyFaces still fails since we append the component id (resulting in form:j_id_g: Password fields must match), and the test checks for an exact match in the message. We may need to update the MyFaces impl to pass the test unless the test should be updated to check for contains...? I will follow up on this.

[volosied]

@BalusC @arjantijms

Would the community allow another update to the tests? MyFaces prefixes the message with the form id as indicated in my comment above (form:j_id_g: Password fields must match). This fails due to assertEquals check. Proposed fix would be to check if the message is contained instead.

MyFaces tries to use the label first, but, if nonexistent, it defaults to the id:
https://github.com/apache/myfaces/blob/e9fe59f96410f31a7f5c0fbd6838c1a22683a691/impl/src/main/java/org/apache/myfaces/util/MessageUtils.java#L760

Exception handling occurs here: https://github.com/apache/myfaces/blob/e9fe59f96410f31a7f5c0fbd6838c1a22683a691/impl/src/main/java/org/apache/myfaces/component/validate/WholeBeanValidator.java#L145-L149

Currently the TCK tests here use assertEquals.

faces/tck/faces23/validateWholeBean/src/test/java/ee/jakarta/tck/faces/test/javaee8/validateWholeBean/Issue4083IT.java

Line 96 in 3431822

assertEquals("Password fields must match", page1.getElementById("err").getElementsByTagName("li").get(0).asNormalizedText());

faces/tck/faces23/validateWholeBean/src/test/java/ee/jakarta/tck/faces/test/javaee8/validateWholeBean/Issue4313IT.java

Line 93 in 3431822

assertEquals("Password fields must match", page1.getElementById("form:err").getElementsByTagName("li").get(0).asNormalizedText());

Draft Change:

 assertTrue("Validation message not found!", page1.getElementById("<ERROR ID>").getElementsByTagName("li").get(0).asNormalizedText().contains("Password fields must match");

Thanks!