Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Faces 4.1 Change Log #1876

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

pnicolucci
Copy link
Contributor

Initial Faces 4.1 Change Log for specification.

I've created this Change Log based off of the following list of issues: https://github.com/jakartaee/faces/issues?q=is%3Aissue+milestone%3A4.1+is%3Aclosed.

I added a Java SE entry and copied the issue title for each issue in Faces 4.1.

@BalusC
Copy link
Member

BalusC commented Feb 3, 2024

Looks great. Only one entry is missing: #1864 I forgot to put 4.1 milestone on the ticket, I only put it on the associated PR.

@pnicolucci pnicolucci force-pushed the UpdateChangeLogForFaces41 branch from a2a0c2e to 2173bd1 Compare February 5, 2024 12:50
@pnicolucci
Copy link
Contributor Author

Thanks for the review @BalusC , I've added the issue you mentioned to the changelog. Let me know if you see anything else that needs to be changed before merging.

Should I make the same commit to the master branch or will 4.1 eventually be merged into master?

@BalusC
Copy link
Member

BalusC commented Feb 5, 2024

Should I make the same commit to the master branch or will 4.1 eventually be merged into master?

Master is 4.0, you probably meant 5.0 branch. Unintuitive yes, but that's apparently required by TCK. @arjantijms can explain the tech limitations, I do not understand these. And yes, I'll make sure 5.0 catches up all changes in 4.1.

@pnicolucci
Copy link
Contributor Author

Should I make the same commit to the master branch or will 4.1 eventually be merged into master?

Master is 4.0, you probably meant 5.0 branch. Unintuitive yes, but that's apparently required by TCK. @arjantijms can explain the tech limitations, I do not understand these. And yes, I'll make sure 5.0 catches up all changes in 4.1.

Ah, yes my mistake! Ok if we will catch the 5.0 branch up with all the changes in 4.1 in the future then I'll just merge here once I have a completed review and we should be good to go!

@pnicolucci pnicolucci merged commit 595e72e into jakartaee:4.1 Feb 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants