Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manage_clipboard feature fix #210

Merged
merged 2 commits into from
Aug 11, 2024

Conversation

mgi388
Copy link
Contributor

@mgi388 mgi388 commented Jul 25, 2024

Fixes #209

  • This approach successfully solves the issue for me and lets me build for wasm
  • I don't know what feature names we should use, e.g. if you want to expose to users of this crate the fact that the open URL and clipboard features are related to "egui", then the current prefix is good. If you want to make it agnostic we should ditch the egui_ prefix
  • I bumped the version to 0.25.1 to match crates.io—was there a publish to crates.io but no corresponding commit and tag in here?

@jakobhellermann
Copy link
Owner

I don't know what feature names we should use, e.g. if you want to expose to users of this crate the fact that the open URL and clipboard features are related to "egui", then the current prefix is good. If you want to make it agnostic we should ditch the egui_ prefix

I think the egui_ prefix is fine.

I bumped the version to 0.25.1 to match crates.io—was there a publish to crates.io but no corresponding commit and tag in here?

Looks like it, I forgot to push that commit.

@jakobhellermann jakobhellermann merged commit b113a78 into jakobhellermann:main Aug 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't set bevy_egui feature manage_clipboard on by default
2 participants