Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

اشتباه تایپی #39

Closed
ali-shariati-990 opened this issue Jul 18, 2015 · 7 comments
Closed

اشتباه تایپی #39

ali-shariati-990 opened this issue Jul 18, 2015 · 7 comments

Comments

@ali-shariati-990
Copy link

با سلام.
گزارش یه مورد کوچیک:
تو لیست ماه ها ، ماه پنجم به جای "مرداد" نوشته شده: "امرداد"
(یعنی یه الف اولش اضافه داره)
با تشکر

@behrang
Copy link
Member

behrang commented Jul 18, 2015

@behrang behrang closed this as completed Jul 18, 2015
@mehrdad-shokri
Copy link

@behrang Is there option to provide the get the common name instead?

@behrang
Copy link
Member

behrang commented Aug 25, 2016

Yes, you can override it yourself. Also I think you can use the localization provided by the moment itself.

@mehrdad-shokri
Copy link

Yeah but there should be some kind of option other than forking the repo since so many people want this.

On Thu, Aug 25, 2016 at 3:44 PM +0430, "Behrang Noruzi Niya" [email protected] wrote:

Yes, you can override it yourself. Also I think you can use the localization provided by the moment itself.

You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#39 (comment)

@behrang
Copy link
Member

behrang commented Aug 27, 2016

None of these two need forking the repository. Adding moment localization is just adding a dependency, and overridgin provided localization is a few lines of code in your project.

@mehrdad-shokri
Copy link

you mean override original files in node_modules I don't think that would be a good solution.

@behrang
Copy link
Member

behrang commented Aug 27, 2016

No. Read moment docs about localizing to understand the API. Read http://momentjs.com/docs/#/customization/ and http://momentjs.com/docs/#/i18n/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants