Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve name conflict in Flutter 3.7 #315

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

danReynolds
Copy link
Contributor

Flutter 3.7 now has a showModalBottomSheet https://api.flutter.dev/flutter/material/showModalBottomSheet.html#:~:text=A%20modal%20bottom%20sheet%20is,from%20interacting%20with%20the%20app API that conflicts with the name of this library's APIs when flutter widgets is in scope. To fix this conflict, an aliased import of the library is used in this PR.

@ashish-d-hh
Copy link

Yes I used your's for now

dependency_overrides:
  modal_bottom_sheet:
    git:
      url: https://github.com/danReynolds/modal_bottom_sheet.git
      path: modal_bottom_sheet

@creativecreatorormaybenot
Copy link
Contributor

To directly depend on the pull request:

  modal_bottom_sheet: #^2.1.2
    # Manually use a fix for Flutter 3.7 until the package has been updated.
    # See https://github.com/jamesblasco/modal_bottom_sheet/pull/315.
    git:
      url: https://github.com/jamesblasco/modal_bottom_sheet.git
      ref: 38c6f44d0c4205608618a676a907c2d104d00b52
      path: modal_bottom_sheet

@duythien0912
Copy link

duythien0912 commented Jan 26, 2023

for who using sheet

  sheet: # ^0.0.4+1
    git:
      url: https://github.com/duythien0912/modal_bottom_sheet.git
      ref: main
      path: sheet
  modal_bottom_sheet: #^2.1.2
    git:
      url: https://github.com/duythien0912/modal_bottom_sheet.git
      ref: main
      path: modal_bottom_sheet

@felipecastrosales
Copy link

@jamesblasco, see this 🙏

@mark8044
Copy link

@jamesblasco Can this be pushed to pub.dev as well?

@felipecastrosales
Copy link

TasnimAnas pushed a commit to TasnimAnas/modal_bottom_sheet that referenced this pull request Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants