Skip to content
This repository has been archived by the owner on Nov 2, 2022. It is now read-only.

Cloudflare\Zone\Firewall\AccessRules->rules() "notes" missing #57

Closed
2ge opened this issue Apr 28, 2017 · 0 comments
Closed

Cloudflare\Zone\Firewall\AccessRules->rules() "notes" missing #57

2ge opened this issue Apr 28, 2017 · 0 comments

Comments

@2ge
Copy link

2ge commented Apr 28, 2017

Hi,

there is one property missing in
Cloudflare\Zone\Firewall\AccessRules->rules()

according:
https://api.cloudflare.com/#firewall-access-rule-for-a-zone-list-access-rules

we should be able to search according "notes", which is missing in implementation:

https://github.com/jamesryanbell/cloudflare/blob/master/src/CloudFlare/Zone/Firewall/AccessRules.php#L23
fmp777 pushed a commit to fmp777/cloudflare that referenced this issue Dec 4, 2019
@jamesryanbell
Added notes to Access Rules endpoint. Closes jamesryanbell#57
7ec8bd4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@2ge