v1.6.30 - Updates Extra Code Coverage Plugin (#610)

* Initial commit removing invalid comment

* Upgraded SF scanner dep, verified with act

* Updates Rollup.FlowInput variables to take advantage of the new defaultValue syntax for invocable variables

* Additional null coalescing cleanup

* Fixes #607 by updating Extra Code Coverage plugin. Sews up the behavior of RollupFlowTests.shouldReportErrorWhenConcatDelimiterSetAndNotConcat - thanks to @bfalter for reporting!

.github/workflows/deploy.yml

@@ -55,6 +55,7 @@ jobs:
 
       - name: 'Upload code coverage for LWC to Codecov.io'
         uses: codecov/codecov-action@v3
+        if: ${{ !github.event.act }}
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
           flags: LWC
@@ -63,6 +64,13 @@ jobs:
         run: |
           rm coverage/ -rf
 
+      - name: 'Optionally setup java'
+        uses: actions/setup-java@v4
+        if: ${{ github.event.act }}
+        with:
+          distribution: 'zulu'
+          java-version: '17'
+
       - name: Install & run SFDX Scanner
         run: npm run scan
 
@@ -96,6 +104,7 @@ jobs:
       # Upload Apex code coverage data
       - name: 'Upload Apex code coverage for Apex to Codecov.io'
         uses: codecov/codecov-action@v3
+        if: ${{ !github.event.act }}
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
           flags: Apex

.gitignore

@@ -19,4 +19,5 @@ sfge-*.log.gz
 #OSX
 .DS_Store
 .config
-.vscode
+.vscode
+config/data/act-pr-event.json

README.md

@@ -24,12 +24,12 @@ As well, don't miss [the Wiki](../../wiki), which includes even more info for co
 
 ## Deployment & Setup
 
-<a href="https://login.salesforce.com/packaging/installPackage.apexp?p0=04t6g000008ObNNAA0">
+<a href="https://login.salesforce.com/packaging/installPackage.apexp?p0=04t6g000008ObVhAAK">
   <img alt="Deploy to Salesforce"
        src="./media/deploy-package-to-prod.png">
 </a>
 
-<a href="https://test.salesforce.com/packaging/installPackage.apexp?p0=04t6g000008ObNNAA0">
+<a href="https://test.salesforce.com/packaging/installPackage.apexp?p0=04t6g000008ObVhAAK">
   <img alt="Deploy to Salesforce Sandbox"
        src="./media/deploy-package-to-sandbox.png">
 </a>

extra-tests/classes/RollupFieldInitializerTests.cls

@@ -30,11 +30,7 @@ private class RollupFieldInitializerTests {
     System.assertEquals('', initializer.getDefaultValue(Account.Phone), 'phone');
     System.assertEquals('', initializer.getDefaultValue(Contact.Email), 'email');
     System.assertEquals('', initializer.getDefaultValue(Contact.AccountId), 'reference');
-    System.assertEquals(
-      Task.Subject.getDescribe().getDefaultValue() != null ? Task.Subject.getDescribe().getDefaultValue() : '',
-      initializer.getDefaultValue(Task.Subject),
-      'combobox'
-    );
+    System.assertEquals(Task.Subject.getDescribe().getDefaultValue() ?? '', initializer.getDefaultValue(Task.Subject), 'combobox');
   }
 
   @IsTest

extra-tests/classes/RollupFlowTests.cls

@@ -591,6 +591,7 @@ private class RollupFlowTests {
     );
 
     flowInputs[0].concatDelimiter = ';';
+    flowInputs[0].splitConcatDelimiterOnCalcItem = true;
 
     Exception ex;
     try {
@@ -599,7 +600,10 @@ private class RollupFlowTests {
       ex = e;
     }
 
-    System.assertEquals('Concat delimiter should only be supplied for CONCAT-based rollups.', ex?.getMessage().trim());
+    System.assertEquals(
+      'Concat delimiter should only be supplied for CONCAT-based rollups. Concat options should only be set for CONCAT_DISTINCT operations',
+      ex?.getMessage()
+    );
   }
 
   @IsTest