Update @octokit/rest from v16 to v18
#5
Conversation
kwelch
force-pushed
the
kwelch-upgrade-octokit
branch
from
e49ce52 to
5419121
Compare
|
Updated to rebase from |
src/lib.ts
Outdated
| let pullRequestCreator = pullRequest.data.user | ||
| ? pullRequest.data.user.login | ||
| : "unknownCreator" | ||
| let pullRequestCommits = pullRequest.data.commits | ||
| let pullRequestBaseRef = pullRequest.data.base.ref | ||
| let pullRequestHeadRef = pullRequest.data.head.ref | ||
| let pullRequestUrl = pullRequest.data.html_url | ||
| let pullRequeseGitMergeable = pullRequest.data.mergeable | ||
| let pullRequeseGitRebaseable = pullRequest.data.rebaseable | ||
| let pullRequeseGitMergeable = pullRequest.data.mergeable || false | ||
| let pullRequeseGitRebaseable = pullRequest.data.rebaseable || false |
There was a problem hiding this comment.
These are now nullable, so I put in some defaults that are probably not amazing.
src/lib.ts
Outdated
| string, | ||
| Octokit.PullsListReviewsResponseItem | ||
| > = new Map() | ||
| let latestReviews: Map<string, typeof reviews.data[0]> = new Map() |
There was a problem hiding this comment.
The changes to the definitions of these maps are probably the most odd feeling part of this change. I am actually surprised it worked.
src/lib.ts
Outdated
|
|
||
| for (let review of reviews.data) { | ||
| let prev = latestReviews.get(review.user.login) | ||
| const userLogin = review.user ? review.user.login : "unknownReviewer" |
There was a problem hiding this comment.
review.user?.login ?? "unknownReviwer"
There was a problem hiding this comment.
😅 I was being lazy because I didn't want to update the babel configs.
| @@ -119,10 +120,7 @@ export default async function isMergable(opts: Options): Promise<Result> { | |||
| pendingReviewRequests.push({ name: reviewRequest.login }) | |||
| } | |||
|
|
|||
| let latestStatuses: Map< | |||
| string, | |||
| Octokit.ReposListStatusesForRefResponseItem | |||
There was a problem hiding this comment.
Does this type just not exist anymore?
There was a problem hiding this comment.
They moved to a plugin model and the type is no longer exported it. Actually I found @octokit/types, this looks like the correct option. Let me update to use that.
There was a problem hiding this comment.
So I updated to use this type library, however there is some odd typescript thing happening. It is erroring on properties that typescript has the object is declared as having. Unfortunately, I don't know typescript well enough to debug it further. I attempted to add circle so it would be easier to show the error but I didn't have enough permissions.
I ran into some issues compiling an
octokitlibrary, so I updatetypescriptand it worked.