refactoring some large functions #411
Labels
Comments
|
Could it be split into multiple files or should it still be just one file? |
|
That's a good question. We have at least 3 "classes" already in the js file. One of the beauties of mustache.js is that, same as the original ruby version, it has a short implementation that fits a single file. I would keep it short for now. |
phillipj
added a commit
to phillipj/mustache.js
that referenced
this issue
Jan 7, 2015
Split the old Writer.renderTokens() into several small functions with a single responsible. Fixes janl#411
dasilvacontin
changed the title
srrvnn
pushed a commit
to srrvnn/mustache.js
that referenced
this issue
Nov 1, 2015
srrvnn
pushed a commit
to srrvnn/mustache.js
that referenced
this issue
Nov 1, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
As I mentioned in #406, refactoring some functions would make the codebase easier to maintain, understand and extend. I'm specially looking at parseTemplate (~125 lines) and Writer.prototype.renderTokens (~100 lines).
The text was updated successfully, but these errors were encountered: