Minor changes to make it compatible with both WSH and ASP #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`<script>`, even in comments, triggers `Active Server Pages error 'ASP 0138', Nested Script Block` Error.
Also, using `global ← this` pattern works on WSH but not on ASP, it's better to just Mustache = {}, since its less typing, works on all platforms and it's the the desired behavior.
|
Hi @nagaozen, thanks for the PR! Unfortunately, it's breaking the Travis build: the linter quits. Can you fix it? Cheers! |
|
Fixed with 60c2da8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<script>, even in comments, triggersActive Server Pages error 'ASP 0138', Nested Script BlockError.Also, using
global ← thispattern works on WSH but not on ASP, it's better to just Mustache = {}, since its less typing, works on all platforms and it's the the desired behavior.