Use new electrs error message when an address has a history longer than the configured lookup limit #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janoside
reviewed
Mar 24, 2023
| @@ -223,7 +223,7 @@ block content | |||
| else if (addressDetailsErrors && addressDetailsErrors.length > 0) | |||
| +contentSection | |||
| each err, errIndex in addressDetailsErrors | |||
| if (err.e && err.e && err.e.message == "history too large") | |||
| if (err.e && err.e.message && err.e.message == "history too large") | |||
There was a problem hiding this comment.
This part is wrong (the check for err.e.message already exists).
There was a problem hiding this comment.
Sorry, misread. This looks right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess this updates #190? Makes it work again, at least on my machine (Running electrs 0.9.9)
I removed the reference to #67 since its a different error, and added some deps (
bip32,bs58check) that the explorer wouldnt start without.Also, is the
err.e.message && err.e.message ==necessary? it could be reduced toerr.e.message ==without any adverse effects afaik (but this is JS, so i wouldnt be surprised)Closes #493