Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loader): Prevent foreign loaders from compile lodash #905

Merged
merged 1 commit into from
Mar 25, 2018

Conversation

jantimon
Copy link
Owner

Fixes #786

@mastilver
Copy link
Collaborator

That would prevent confusing issue with html-loader and co, right? That's amazing! ⭐

@jantimon
Copy link
Owner Author

Unfortunately I would only help with only remove the following warning:

[BABEL] Note: The code generator has deoptimised the styling of "~/node_modules/lodash/lodash.js" as it exceeds the max of "500KB".

Stop using webpack module rules inside the loader to get rid of the babel 500kb warning

fix #786
@jantimon jantimon merged commit 7b4eb7f into master Mar 25, 2018
@lock
Copy link

lock bot commented May 31, 2018

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2018
@jantimon jantimon deleted the feature/lodash-fix branch February 16, 2019 14:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants