Teach zipp.Path some additional pathlib.Path methods. #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Covers:
* Path.match
* Path.glob
* Path.rglob
* Path.relative_to
* Path.is_symlink (with trivial implementation given the lack of
symlink support currently)
along with an implementation of Path.__eq__ for testing/comparison
purposes.
Part of the implementation here makes use of CPython internals (from
the pathlib module) but it seems to handle fixing that requires some
refactoring upstream.
Julian
commented
Nov 2, 2022
jaraco
requested changes
Nov 23, 2022
jaraco
reviewed
Nov 25, 2022
|
Tests are failing on Windows, I suspect because relative_to is failing to match the descendants. |
The issue is that |
… test on Windows. Added test for relative paths with subdirectories.
… Instead, assert that its string value resolves to the expected value.
jaraco
reviewed
Nov 25, 2022
jaraco
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers:
along with an implementation of Path.eq for testing/comparison purposes.
Part of the implementation here makes use of CPython internals (from the pathlib module) but it seems to handle fixing that requires some refactoring upstream.