Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the None host #50

Merged
merged 13 commits into from
Aug 16, 2023
Merged

Improve the None host #50

merged 13 commits into from
Aug 16, 2023

Conversation

jaredpar
Copy link
Owner

@jaredpar jaredpar commented Aug 15, 2023

This work is the result of investigating issue #49 and causes the following changes to how the None analyzer host works.

  1. The compiler log now records whether or not generated files were able to be read. This does not mean there are generated files, just that the log creation was able to successfully probe for them. This will be false when a build failed, native PDBs are used, etc ...
  2. The reader now uses an in memory source generator to add back the generated files. That means every host has to go through the CompilationData.GetCompilationAfterGenerators code path. This makes consumption uniform for all the analyzer host kinds.
  3. When (1) above fails then GetCompilationAfterGenerators will have a diagnostic stating this. That means consumers won't silently run into this problem.
  4. Threaded through the ability to use the None analyzer host on a few of the command line options.

closes #49

work arounds for KirillOsenkov/MSBuildStructuredLog#699

@jaredpar jaredpar merged commit 51ed519 into main Aug 16, 2023
2 checks passed
@jaredpar jaredpar deleted the none branch August 16, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generators don't get loaded properly
1 participant