compress-brotli - updating linting to be more inline (#1265)

jaredwray · Dec 24, 2024 · afc0a1c · afc0a1c
1 parent 6573d3f
commit afc0a1c
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 14 deletions.
diff --git a/packages/compress-brotli/package.json b/packages/compress-brotli/package.json
@@ -21,13 +21,7 @@
 	},
 	"xo": {
 		"rules": {
-			"import/no-named-as-default": "off",
-			"unicorn/prefer-module": "off",
-			"@typescript-eslint/no-unsafe-call": "off",
-			"@typescript-eslint/consistent-type-definitions": "off",
-			"@typescript-eslint/no-unsafe-argument": "off",
-			"import/extensions": "off",
-			"import/no-extraneous-dependencies": "off"
+			"@typescript-eslint/no-unsafe-assignment": 0
 		}
 	},
 	"repository": {
@@ -59,8 +53,10 @@
 	},
 	"devDependencies": {
 		"@keyv/test-suite": "workspace:^",
+		"@vitest/coverage-v8": "^2.1.8",
 		"c8": "^10.1.2",
 		"rimraf": "^6.0.1",
+		"vitest": "^2.1.8",
 		"xo": "^0.60.0"
 	},
 	"tsd": {

diff --git a/packages/compress-brotli/src/index.ts b/packages/compress-brotli/src/index.ts
@@ -12,6 +12,7 @@ export class KeyvBrotli {
 	}
 
 	async compress(value: any, options?: BrotliOptions): CompressResult {
+		// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
 		return this.brotli.compress(value, options);
 	}
 

diff --git a/packages/compress-brotli/src/types.ts b/packages/compress-brotli/src/types.ts
@@ -14,18 +14,18 @@ export type Serialize = {
 	expires?: number;
 };
 
-export interface Options {
+export type Options = {
 	compressOptions?: BrotliOptions;
 	decompressOptions?: BrotliOptions;
 	enable?: boolean;
 	serialize?: any;
 	deserialize?: any;
 	iltorb?: any;
-}
+};
 
-export interface Brotli {
+export type Brotli = {
 	serialize: BrotliSerialize<SerializeResult>;
 	deserialize: BrotliDeserialize<DeserializeResult>;
 	compress: (data: InputType, options?: BrotliOptions) => CompressResult;
 	decompress: (data: InputType, options?: BrotliOptions) => DecompressResult;
-}
+};
diff --git a/packages/compress-brotli/test/types.ts b/packages/compress-brotli/test/types.ts
@@ -1,7 +1,7 @@
 import zlib from 'node:zlib';
 import v8 from 'node:v8';
 import * as test from 'vitest';
-import Keyv, {type KeyvStoreAdapter} from 'keyv';
+import {Keyv} from 'keyv';
 import KeyvBrotli from '../src/index.js';
 
 type MyType = {
@@ -11,7 +11,6 @@ type MyType = {
 
 test.it('default options', async t => {
 	const keyv = new Keyv({
-		// @ts-expect-error - KeyvBrotli and CompressionAdapter type
 		compression: new KeyvBrotli(),
 	});
 

diff --git a/packages/compress-brotli/vitest.config.ts b/packages/compress-brotli/vitest.config.ts
@@ -1,4 +1,4 @@
 import {defineConfig, mergeConfig} from 'vitest/config';
-import vitestConfig from '../../vitest.general.config';
+import vitestConfig from '../../vitest.general.config.js';
 
 export default mergeConfig(vitestConfig, defineConfig({}));
-Original file line number
+Diff line change
@@ Expand Up / @@ -12,6 +12,7 @@ export class KeyvBrotli { @@
     	}
     	async compress(value: any, options?: BrotliOptions): CompressResult {
+    		// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
     		return this.brotli.compress(value, options);
     	}
@@ Expand Down @@