Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update keyv events errors handling #1249

Merged
merged 11 commits into from
Dec 12, 2024

Conversation

Sadzurami
Copy link
Contributor

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

ref: #1248

@Sadzurami Sadzurami changed the title fix: update error handling in Keyv class to respect emitErrors option fix: update keyv events errors handling Dec 12, 2024
@jaredwray
Copy link
Owner

@Sadzurami - thanks for the fixes and updates. I added in unit tests and will get this merged.

@jaredwray
Copy link
Owner

@Sadzurami - most likely this will get released in the next 2-3 weeks

@jaredwray jaredwray merged commit fb9a5c5 into jaredwray:main Dec 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants