Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add compress lz4-napi #1284

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

0xslipk
Copy link
Contributor

@0xslipk 0xslipk commented Jan 19, 2025

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Feature)

@jaredwray
Copy link
Owner

@0xslipk - thanks so much for the contribution. Is it ok if we rename the package and folder to just ‘@keyv/compress-lz4’

@jaredwray
Copy link
Owner

@0xslipk - I have a local build with some changes on this. Do you want to make it so I can push to your branch?

@0xslipk
Copy link
Contributor Author

0xslipk commented Jan 19, 2025

@0xslipk - thanks so much for the contribution. Is it ok if we rename the package and folder to just ‘@keyv/compress-lz4’

Yeah, no problem. I will do it tomorrow.

@0xslipk
Copy link
Contributor Author

0xslipk commented Jan 19, 2025

@0xslipk - I have a local build with some changes on this. Do you want to make it so I can push to your branch?

You can push to my branch 😬

@0xslipk
Copy link
Contributor Author

0xslipk commented Jan 20, 2025

@jaredwray just sent and invite
image

@0xslipk
Copy link
Contributor Author

0xslipk commented Jan 20, 2025

@0xslipk - thanks so much for the contribution. Is it ok if we rename the package and folder to just ‘@keyv/compress-lz4’

@jaredwray done 🚀

@jaredwray jaredwray merged commit cc89168 into jaredwray:main Jan 20, 2025
5 checks passed
@jaredwray
Copy link
Owner

@0xslipk - thanks so much and we will get this released today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants