-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coffee Tags #4346
Closed
+114
−6
Closed
Coffee Tags #4346
Changes from 40 commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
deaaaab
add support for CoffeeTags
shreeve d257482
add compiled files from /lib
shreeve 247f69b
add compiled browser build
shreeve e05ce00
typo
shreeve 2177aa4
make some trailing commas implicit
shreeve 5b3643f
update compiled file
shreeve 591dc22
support dotted class names
shreeve 7abb41a
compiled files
shreeve e227da0
remove old debugging statement
shreeve 2e57083
Add @ support: <div.active@menu> yields <div class="active" id="menu">
shreeve 2c8335f
compiled versions
shreeve 607d22a
make some tweaks for Vuejs -- revisit this to keep us generic
shreeve 8905f7e
compiled file
shreeve 046c754
include the simplified version in the comments
shreeve 4c4bc07
make CSX token handling more like JS token
shreeve 6fb7bcd
compiled version
shreeve b62b851
be more permissive in matching tags
shreeve ddcf651
more elegant tag parsing and token generation
shreeve 899bc13
compiled files
shreeve afae4d1
put #id before .classes
shreeve 6dbd4ad
compiled files
shreeve a05214c
typo
shreeve 4d69839
compiled file
shreeve 203d6e1
use proper syntax
shreeve bf2f856
compiled file
shreeve 1c17b5a
allow final "!" to indicate unsafe HTML
shreeve 4ea81a0
add support for rawHTML
shreeve ed4fe15
compiled files
shreeve 189d353
try simpler, generic approach
shreeve 496db51
compiled file
shreeve 5fd3f41
fix math
shreeve b73bdbb
compiled file
shreeve 10d95d6
back to simplest approach
shreeve 470a899
compiled file
shreeve 394e66a
use h() instead of coffeeTags() -- better or worse?
shreeve bffc9bc
compiled file
shreeve f327cd9
wip - for custom render function
shreeve 0169fa6
allow trailing ? (and the original ! too)
shreeve 627cbb7
compiled file
shreeve 9f89946
Add HERETAG support using <*>
shreeve b082c98
compiled file
shreeve ad77113
allow <!fooBar> to set custom render function to fooBar()
shreeve e25efa6
compiled files
shreeve 824728e
Clarify that <!fooBar!> (a bang on both ends) set the custom render f…
shreeve faafbe5
merge with live
shreeve 757acef
test empty commit to see if both PRs update
shreeve File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can’t merge in this PR if what it does is replace this new coffee tag literal with calls to a mysterious
h
function that is not defined within CoffeeScript. That makes coffee tags dependant on some external library to supply thish
function in the global scope.