Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default bootstrap [January 2021] #180

Merged

Conversation

brody4hire
Copy link

(with some security updates)

Thanks again to @jasongin for publishing and supporting this super-awesome project!

@zsoltlengyelit
Copy link
Contributor

hi @jasongin , are you going to merge this pr?

our company likes this tool very much & thanks four your efforts!

@jasongin
Copy link
Owner

jasongin commented Feb 2, 2021

Thanks for the reminder. Looking at this now, my only hesitation is that this will significantly increase the initial download size. For some reason, the size of the Node.js distribution package increased by about 50% from v12 to v14. (Windows 10.7 MB -> 17.2 MB, Mac 13.7 MB -> 20.2 MB). It appears to be the node binary that increased by a lot. Does anyone know why?

@jasongin
Copy link
Owner

jasongin commented Feb 2, 2021

I see the size increase is due to full ICU support: nodejs/help#3114

@brody4hire
Copy link
Author

Aargh! We could continue using Node.js 12 until it reaches EOL. I did check out deno but it seems to be getting large as well: https://github.com/denoland/deno/releases

Any more ideas ... anyone?

@brody4hire brody4hire changed the title update default bootstrap to Node.js 14.15.4 update default bootstrap [January 2021] Feb 2, 2021
defaults.json Outdated Show resolved Hide resolved
@brody4hire brody4hire marked this pull request as draft February 2, 2021 23:18
@brody4hire brody4hire marked this pull request as ready for review February 3, 2021 00:25
@brody4hire
Copy link
Author

@jasongin I have changed it to use 12.20.1 and tested on both macOS and Windows machines.

From https://nodejs.org/en/about/releases/ it looks like we have until April next year to find another solution.

I hope this can be reviewed and merged now. Thanks again!

@jasongin jasongin merged commit 5a2b954 into jasongin:master Feb 3, 2021
@jasongin
Copy link
Owner

jasongin commented Feb 3, 2021

Thanks!

@brody4hire brody4hire deleted the update-default-bootstrap-2021-01 branch February 3, 2021 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants