Handle $KEEP_NUM_RECENT being set to 0
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents errors like: du: cannot access `/var/backup/backup_2015-02-10-1423608909': No such file or directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for open sourcing this! I looked around at a lot of options and this fit my needs best.
I was playing around with these config options:
And noticed errors like:
This change accounts for the possibility that the local backups may have been immediately rotated out. Another approach would be to check and store the disk space used before rotating. This is the quick and dirty "solution" to get the discussion started, I'd be happy to dig deeper to come up with a better PR :)
Edit: …although checking the disk space ahead of time it would still be displaying a non-existent directory so that probably wouldn't make sense. So this is maybe the simplest and least confusing solution for this without having to check S3 configuration and all that.