Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code editors #22

Merged
merged 5 commits into from
Jun 28, 2020
Merged

Code editors #22

merged 5 commits into from
Jun 28, 2020

Conversation

ayushhagarwal
Copy link
Contributor

Hindi translation done for Code Editors documentation in javascript.info.

Heading changed for testing work not completed
Complete article translated to hindi.
@CLAassistant
Copy link

CLAassistant commented Jun 27, 2020

CLA assistant check
All committers have signed the CLA.

@theBstar theBstar changed the title Code Editors Code editors Jun 27, 2020
@theBstar
Copy link
Member

Hey added a bunch of comments feel free to disagree. Nice job overall. Sometimes you need to play around with the English version to get the translation right when using automated tools. The translated version not only has to be correct but meaningful in the context as well. Thanks for your time, Now let's wrap this up asap. 👍

Copy link
Member

@theBstar theBstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some comments where I thought we could improve. This looks good to be merged post changes. Feel free to disagree!

1-js/01-getting-started/3-code-editors/article.md Outdated Show resolved Hide resolved
1-js/01-getting-started/3-code-editors/article.md Outdated Show resolved Hide resolved
1-js/01-getting-started/3-code-editors/article.md Outdated Show resolved Hide resolved
1-js/01-getting-started/3-code-editors/article.md Outdated Show resolved Hide resolved
1-js/01-getting-started/3-code-editors/article.md Outdated Show resolved Hide resolved
1-js/01-getting-started/3-code-editors/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@ayushhagarwal
Copy link
Contributor Author

/done

Copy link
Member

@theBstar theBstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to be merged. There are certain possible improvements around the context and meanings though. Can be merged now.

@theBstar theBstar merged commit 6ec932a into javascript-tutorial:master Jun 28, 2020
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants