Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1720 random-min-max 해답 번역 첫번째 줄 #1732

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

#1720 random-min-max 해답 번역 첫번째 줄 #1732

wants to merge 7 commits into from

Conversation

kenna-hwa
Copy link

@kenna-hwa kenna-hwa commented Dec 1, 2023 •
edited
Loading

요약

[신규 번역]

숫자형 과제 번역 (random-min-max 과제 해설의 첫번째 줄)

연관 이슈

#1720

Pull Request 체크리스트

TODO

  • 번역 규칙을 확인하셨나요?
    • 줄 바꿈과 단락을 '원문과 동일하게' 유지하셨나요?
    • 맞춤법 검사기로 맞춤법을 확인하셨나요?
    • 마크다운 문법에 사용되는 공백(스페이스), 큰따옴표("), 작은따옴표('), 대시(-), 백틱(`) 등의 특수문자는 그대로 두셨나요?
  • 로컬 서버 세팅 후 최종 결과물을 확인해 보셨나요?
  • PR 하나엔 번역문 하나만 넣으셨나요?
  • 의미 있는 커밋 메시지를 작성하셨나요?
    • 예시
      • [프락시] 번역
      • [프락시] 과제 번역
      • [if문과 조건부 연산자 '?'] 리뷰
      • [주석] 2차 리뷰
      • [Date 객체와 날짜] 번역

@javascript-translate-bot javascript-translate-bot requested a review from a team December 1, 2023 07:25
@CLAassistant
Copy link

CLAassistant commented Dec 1, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Violet-Bora-Lee
Violet-Bora-Lee reviewed Dec 1, 2023
View reviewed changes
1-js/05-data-types/02-number/8-random-min-max/solution.md Outdated
@@ -1,4 +1,4 @@
We need to "map" all values from the interval 0..1 into values from `min` to `max`.
우리는 0부터 1까지의 모든 값을 `최소값`부터 `최대값`까지의 "매핑"해야합니다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
우리는 0부터 1까지의 모든 값을 `최소값`부터 `최대값`까지의 "매핑"해야합니다.
우리는 0부터 1까지의 모든 값을 `min`부터 `max`까지의 범위로 '매핑' 해야합니다.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/javascript-tutorial/ko.javascript.info/wiki/%EB%B2%88%EC%97%AD-%EB%AA%A8%EB%B2%94-%EC%82%AC%EB%A1%80

기여 가이드를 읽고 진행해주세요.

Violet-Bora-Lee
Violet-Bora-Lee requested changes Dec 1, 2023
View reviewed changes
1-js/05-data-types/02-number/8-random-min-max/solution.md Outdated
@@ -1,4 +1,4 @@
We need to "map" all values from the interval 0..1 into values from `min` to `max`.
우리는 0부터 1까지의 모든 값을 `최소값`부터 `최대값`까지의 "매핑"해야합니다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/javascript-tutorial/ko.javascript.info/wiki/%EB%B2%88%EC%97%AD-%EB%AA%A8%EB%B2%94-%EC%82%AC%EB%A1%80

기여 가이드를 읽고 진행해주세요.

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@kenna-hwa
Copy link
Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team December 3, 2023 09:18
Violet-Bora-Lee
Violet-Bora-Lee requested changes Dec 6, 2023
View reviewed changes
Copy link
Member

@Violet-Bora-Lee Violet-Bora-Lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR에 본인이 작성하지 않은 커밋들이 들어가있습니다.
작업 브랜치를 적절히 갱신해주세요.

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Violet-Bora-Lee Violet-Bora-Lee Violet-Bora-Lee requested changes

Assignees
No one assigned
Labels
changes requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kenna-hwa @CLAassistant @javascript-translate-bot @Violet-Bora-Lee @ArtistGodGun