Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functions #127

Merged
merged 16 commits into from
Jul 13, 2021
Merged

Functions #127

merged 16 commits into from
Jul 13, 2021

Conversation

hypeofpipe
Copy link
Contributor

Привіт всім

Вибачаюсь за таку затримку, мої ГітХаб сповіщення були в відділі "спам", ха-ха, дякую Гугл.

Буду старатись переводити далі.

@javascript-translate-bot javascript-translate-bot requested a review from a team November 6, 2020 23:39
@javascript-translate-bot
Copy link
Contributor

Error: the article has another translator @hypeofpipe) _[started translation](#1 (comment) in the Progress Issue #1.

@CLAassistant
Copy link

CLAassistant commented Nov 6, 2020 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ tarasyyyk
❌ hypeofpipe
You have signed the CLA already but the status is still pending? Let us recheck it.

@tarasyyyk
Copy link
Collaborator

tarasyyyk commented Nov 7, 2020 •
edited
Loading

Мені сподобався переклад коду та коментарів! Чудово!

@tarasyyyk tarasyyyk mentioned this pull request Nov 7, 2020
Open
tarasyyyk
tarasyyyk requested changes Nov 7, 2020
View reviewed changes
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@tarasyyyk
Copy link
Collaborator

Привіт, @hypeofpipe !
Є прогрес з перекладом?

tarasyyyk and others added 11 commits July 13, 2021 21:54
@tarasyyyk
Update 1-js/02-first-steps/15-function-basics/article.md
8a08422
@tarasyyyk
Update 1-js/02-first-steps/15-function-basics/article.md
d1b38cb
@tarasyyyk
Update 1-js/02-first-steps/15-function-basics/article.md
9347c84
@tarasyyyk
Update 1-js/02-first-steps/15-function-basics/article.md
99a4606
@tarasyyyk
Update 1-js/02-first-steps/15-function-basics/article.md
7360f68
@tarasyyyk @UkrainianCitizen
Update 1-js/02-first-steps/15-function-basics/article.md
81913d5 
Co-authored-by: UkrainianCitizen <[email protected]>
@tarasyyyk
Update 1-js/02-first-steps/15-function-basics/article.md
9476b85
@tarasyyyk
Update 1-js/02-first-steps/15-function-basics/article.md
b68b89a
@tarasyyyk
Update 1-js/02-first-steps/15-function-basics/article.md
e55c3c9
@tarasyyyk @UkrainianCitizen
Update 1-js/02-first-steps/15-function-basics/article.md
6c99a89 
Co-authored-by: UkrainianCitizen <[email protected]>
@tarasyyyk @UkrainianCitizen
Update 1-js/02-first-steps/15-function-basics/article.md
2ac2bc3 
Co-authored-by: UkrainianCitizen <[email protected]>
@tarasyyyk tarasyyyk changed the base branch from master to function-basics July 13, 2021 19:22
@tarasyyyk tarasyyyk marked this pull request as ready for review July 13, 2021 19:48
@tarasyyyk tarasyyyk merged commit 2657e40 into javascript-tutorial:function-basics Jul 13, 2021
@tarasyyyk tarasyyyk mentioned this pull request Jul 13, 2021
Merged
@tarasyyyk
Copy link
Collaborator

tarasyyyk commented Jul 13, 2021 •
edited
Loading

Виправив деякі конфлікти з гілкою master і злив даний PR в гілку function-basics (яка буде видала після закінчення перекладу). Продовжу переклад в #144.

Дякую, @hypeofpipe за переклад!

@tarasyyyk
Copy link
Collaborator

@all-contributors add @hypeofpipe for translation.

@allcontributors allcontributors bot mentioned this pull request Jul 13, 2021
Merged
@allcontributors
Copy link
Contributor

@tarasyyyk

I've put up a pull request to add @hypeofpipe! 🎉

tarasyyyk added a commit that referenced this pull request Aug 12, 2021
@tarasyyyk @hypeofpipe
@UkrainianCitizen @dolgachio
Functions (#144)
f21f302 
* Functions (#127)

* First part of article.md

* Translate 'Alternative default parameters'

* Fix lines

* Translate 'Returning value'

* Translate 'Naming a function'

* Translate 'Functions == Comments'

* Translate 'Summary'

* Translate tasks

* Small correction

Co-authored-by: Volodymyr V <[email protected]>
Co-authored-by: UkrainianCitizen <[email protected]>
Co-authored-by: Stanislav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UkrainianCitizen UkrainianCitizen UkrainianCitizen left review comments

@tarasyyyk tarasyyyk tarasyyyk requested changes

Assignees
No one assigned
Labels
changes requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hypeofpipe @javascript-translate-bot @CLAassistant @tarasyyyk @UkrainianCitizen