Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logical operators #34

Merged
merged 10 commits into from
Jul 16, 2019
Merged

Logical operators #34

merged 10 commits into from
Jul 16, 2019

Conversation

Zim123
Copy link
Contributor

@Zim123 Zim123 commented Jul 16, 2019

Pull request for translation #29

@javascript-translate-bot javascript-translate-bot requested a review from a team July 16, 2019 15:58
tarasyyyk
tarasyyyk requested changes Jul 16, 2019
View reviewed changes
Copy link
Collaborator

@tarasyyyk tarasyyyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You did a great job. There was a lot of text to translate.
Please, made some small changes I mentioned in review and change words "OR", "AND", "NOT" to "АБО", "І", "НЕ". You can use "Find & Replace" feature in editor.

1-js/02-first-steps/11-logical-operators/2-alert-or/task.md Outdated Show resolved Hide resolved
1-js/02-first-steps/11-logical-operators/6-check-if-in-range/task.md Outdated Show resolved Hide resolved
1-js/02-first-steps/11-logical-operators/9-check-login/task.md Outdated Show resolved Hide resolved
1-js/02-first-steps/11-logical-operators/9-check-login/task.md Outdated Show resolved Hide resolved
1-js/02-first-steps/11-logical-operators/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/11-logical-operators/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/11-logical-operators/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/11-logical-operators/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/11-logical-operators/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@Zim123
Copy link
Contributor Author

Zim123 commented Jul 16, 2019

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team July 16, 2019 17:16
@tarasyyyk tarasyyyk merged commit de2cff6 into javascript-tutorial:master Jul 16, 2019
@tarasyyyk tarasyyyk mentioned this pull request Jul 16, 2019
Closed
@iliakan iliakan mentioned this pull request Jul 16, 2019
Open
@tarasyyyk
Copy link
Collaborator

@Zim123 thanks for your contribution!

@all-contributors add @Zim123 for translation.

@allcontributors allcontributors bot mentioned this pull request Mar 6, 2020
Merged
@allcontributors
Copy link
Contributor

@tarasyyyk

I've put up a pull request to add @Zim123! 🎉

@Zim123
Copy link
Contributor Author

Zim123 commented Mar 6, 2020

@tarasyyyk no problem :)
I'm having some changes related to work, so I hope it will stabilize soon, and I will be back to proceed with the translation :)

@tarasyyyk tarasyyyk removed the needs +1 label Mar 6, 2020
@tarasyyyk tarasyyyk changed the title 1 02 11 logical operators Logical operators Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarasyyyk tarasyyyk tarasyyyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zim123 @javascript-translate-bot @tarasyyyk