Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shadow DOM styling #418

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Shadow DOM styling #418

merged 2 commits into from
Dec 8, 2022

Conversation

SamGreenberg
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 23, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@javascript-translate-bot javascript-translate-bot mentioned this pull request Nov 23, 2022
Open
dolgachio
dolgachio requested changes Dec 7, 2022
View reviewed changes
Copy link
Collaborator

@dolgachio dolgachio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дякую, за чудовий переклад! Подивіться, будь ласка, мої коментарі :)

8-web-components/6-shadow-dom-style/article.md Outdated Show resolved Hide resolved
8-web-components/6-shadow-dom-style/article.md Outdated Show resolved Hide resolved
8-web-components/6-shadow-dom-style/article.md Outdated Show resolved Hide resolved
8-web-components/6-shadow-dom-style/article.md Outdated Show resolved Hide resolved
8-web-components/6-shadow-dom-style/article.md Outdated Show resolved Hide resolved
8-web-components/6-shadow-dom-style/article.md Outdated Show resolved Hide resolved
8-web-components/6-shadow-dom-style/article.md Outdated Show resolved Hide resolved
8-web-components/6-shadow-dom-style/article.md Outdated Show resolved Hide resolved
8-web-components/6-shadow-dom-style/article.md Outdated Show resolved Hide resolved
8-web-components/6-shadow-dom-style/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@SamGreenberg @dolgachio
code review fixes
cfd3f68 
Co-authored-by: Stanislav <[email protected]>
@SamGreenberg
Copy link
Contributor Author

/done

@dolgachio
Copy link
Collaborator

dolgachio commented Dec 8, 2022 •
edited
Loading

@all-contributors add @SamGreenberg for translation

1 similar comment
@dolgachio
Copy link
Collaborator

@all-contributors add @SamGreenberg for translation

@allcontributors allcontributors bot mentioned this pull request Dec 8, 2022
Merged
@allcontributors
Copy link
Contributor

@stas-dolgachov

I've put up a pull request to add @SamGreenberg! 🎉

dolgachio
dolgachio approved these changes Dec 8, 2022
View reviewed changes
Copy link
Collaborator

@dolgachio dolgachio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ще раз дякую за ваш внесок!

@dolgachio dolgachio merged commit 5a9e098 into javascript-tutorial:master Dec 8, 2022
@javascript-translate-bot
Copy link
Contributor

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dolgachio dolgachio dolgachio approved these changes

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SamGreenberg @CLAassistant @javascript-translate-bot @dolgachio