Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function expression and arrows #48

Merged

Conversation

Tuoris
Copy link
Contributor

@Tuoris Tuoris commented Oct 23, 2019

Note: given the fact that some words and phrases are yet missing from glossary,
I use following translations (source - MDN 🇺🇦) for them:

  • Function Declaration -> Оголошення Функції, left both words capitalized for better clarity and readability
  • Function Expression -> Функціональний Вираз, left both words capitalized for the same reason
  • expression -> вираз
  • strict mode -> суворий режим
  • callback -> колбек/функція зворотного виклику, source - Wiki 🇺🇦

Bonus 😆 :

  • John -> Микола - most common ukrainian first name according to Internet

@tarasyyyk
Copy link
Collaborator

@Tuoris
Copy link
Contributor Author

Tuoris commented Oct 23, 2019

Good point, @tarasyyyk !

  • callback - I feel that колбек and функція зворотного виклику are synonyms and both can be used. Please create an issue if needed (I personally think it's not)
  • strict mode - most voted translation is used (few weeks left)
  • John - sure, I'll change Микола -> Іван (yet russian version uses Вася) )

Edit: fix typo

@CLAassistant
Copy link

CLAassistant commented Oct 23, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@tarasyyyk tarasyyyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! There are a lot of text and no any major mistakes. This is the first such pull request!
Some translation even better that english source text (I mean Error => ReferenceError).

@tarasyyyk tarasyyyk merged commit 66b0a58 into javascript-tutorial:master Oct 23, 2019
@tarasyyyk
Copy link
Collaborator

@all-contributors add @Tuoris for translation.

@allcontributors
Copy link
Contributor

@tarasyyyk

I've put up a pull request to add @Tuoris! 🎉

@tarasyyyk tarasyyyk changed the title Translation: First steps > Function expression and arrows Function expression and arrows Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants