Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding style #59

Merged
merged 27 commits into from
Feb 27, 2020
Merged

Coding style #59

merged 27 commits into from
Feb 27, 2020

Conversation

alexgalkin
Copy link
Contributor

Another attempt to prepare PR for translation (as mentioned previously SVG will be changed using YAML file later). Please review and comment.

Copy link
Collaborator

@tarasyyyk tarasyyyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good translation!
Please, made small corrections and I'll merge this PR.


Our code must be as clean and easy to read as possible.
Наш код повинен бути настільки чистим та зрозумілим наскільки це можливо.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

«настільки зрозумілим та читабельним, наскільки це можливо»

@@ -34,15 +34,15 @@ if (n < 0) {

-->

Now let's discuss the rules and reasons for them in detail.
Давайте розберемо ці правила і причини їх з'явлення більш детально.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

«Давайте детальніше розглянемо ці правила і причини їх появи»

1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@alexgalkin alexgalkin requested a review from tarasyyyk February 26, 2020 22:45
@alexgalkin
Copy link
Contributor Author

/done

Copy link
Collaborator

@tarasyyyk tarasyyyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last small correction need to be fixed before merge.

1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@alexgalkin alexgalkin requested a review from tarasyyyk February 27, 2020 18:37
Copy link
Collaborator

@tarasyyyk tarasyyyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thank you for contribution!

@tarasyyyk tarasyyyk merged commit c792b67 into javascript-tutorial:master Feb 27, 2020
@tarasyyyk tarasyyyk removed the needs +1 label Mar 6, 2020
@tarasyyyk tarasyyyk changed the title Translate Code Style section Coding style Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants