Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode character properties \p #343

Merged
merged 14 commits into from Jun 2, 2019
Merged

Unicode character properties \p #343

merged 14 commits into from Jun 2, 2019

Conversation

ghost
Copy link

@ghost ghost commented May 19, 2019

Translated it to Chinese.

@CLAassistant
Copy link

CLAassistant commented May 19, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ leviding
❌ fakeinc


fakeinc seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@leviding
Copy link
Member

leviding commented May 21, 2019

@fakeinc 感谢 PR
路径应该是 9-regular-expressions/21-regexp-unicode-properties/article.md,麻烦修改

原文链接:https://github.com/javascript-tutorial/en.javascript.info/blob/master/9-regular-expressions/21-regexp-unicode-properties/article.md

@ghost
Copy link
Author

ghost commented May 21, 2019

@fakeinc 感谢 PR
路径应该是 9-regular-expressions/21-regexp-unicode-properties/article.md,麻烦修改

原文链接:https://github.com/javascript-tutorial/en.javascript.info/blob/master/9-regular-expressions/21-regexp-unicode-properties/article.md

感谢指出。但在比较后我发现中文 Repo 里很多文件夹的命名与英文 Repo 中文件夹的命名都不对应。例如整个 Regular Expressions 部分英文 Repo 中都是在 9-regular-expression 文件夹下的,而中文 Repo 中此部分都在 5-regular-expression 文件夹下。

请问我应该做以下哪一个:

  1. 创建一个与英文版命名相同的文件夹并将原来的文章与这篇文章一起转移到这个文件夹
  2. 创建一个与英文版命名相同的文件夹并将这篇文章转移到这个文件夹

谢谢。

@leviding
Copy link
Member

@fakeinc 创建一个与英文版命名相同的文件夹并将这篇文章转移到这个文件夹,暂时只管这一篇文章即可。

@ghost
Copy link
Author

ghost commented May 29, 2019 via email

…to 9-regular-expressions/21-regexp-unicode-properties/article.md
@ghost
Copy link
Author

ghost commented May 31, 2019

@fakeinc 创建一个与英文版命名相同的文件夹并将这篇文章转移到这个文件夹,暂时只管这一篇文章即可。

已修复。

@leviding
Copy link
Member

@fakeinc 赞,我这找人尽快校对一下就 merge。

Copy link
Member

@leviding leviding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我找前端人来校对

@@ -0,0 +1,91 @@
# Unicode 类别 \p
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unicode character properties 只翻译成 Unicode 类别是否不妥

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢。我会采用 Mcskiller 的建议

Copy link
Contributor

@lebenito030 lebenito030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leviding 校对完成,修正了部分格式错误,然后一些翻译给了一点建议,可以参考一下,辛苦了

@@ -0,0 +1,91 @@
# Unicode 类别 \p
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unicode character properties 可以考虑翻译为『 Unicode 字符属性类别』更具体一点,后续的 \p 也是说按照每一个字符的属性类别来进行匹配

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢。但属性和类别可能不应直接连起来,我认为『 Unicode 字符属性:类别』可能会更好。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里感觉会导致含义变成『Unicode 字符属性』的子章节,也可以考虑直接译为『Unicode 属性匹配』

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的。

@ghost
Copy link
Author

ghost commented Jun 1, 2019

已经检查了所有的建议并做出了一些修改。

Copy link
Member

@leviding leviding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

很赞,翻译和校对辛苦了 👍 有一个地方注意一下,js run 是本系列教程的特殊标注,不修改哈

@leviding leviding merged commit 13a46cc into javascript-tutorial:master Jun 2, 2019
@javascript-translate-bot

No article with the same title in the Progress Issue #324. This PR is not a translation ⁉️

@leviding
Copy link
Member

leviding commented Jun 2, 2019

This is a translation.

@leviding
Copy link
Member

leviding commented Jun 2, 2019

@fakeinc 如果对本系列教程翻译感兴趣,欢迎加我微信 517010193(备注 JS 教程翻译),我会陆续拉一些感兴趣的小伙伴一起维护。

@ghost
Copy link
Author

ghost commented Jun 3, 2019

@fakeinc 如果对本系列教程翻译感兴趣,欢迎加我微信 517010193(备注 JS 教程翻译),我会陆续拉一些感兴趣的小伙伴一起维护。

好的,谢谢。其实我更希望使用 Telegram 这种联系方式。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants