Pluggable user support

[dokterbob]

Implements #62. Supercedes #93.

Please provide some feedback on this for usage with an actual custom user model - there seems no proper way to user custom user models in automated tests.

[dokterbob]

@remarkablerocket, I am planning to merge your implementation of a custom user model. Would be nice if you could test this branch with your custom user model implementaton to assure stability.

Thanks!

[dokterbob]

@s1n4 As the migration in your patch seemed to depend on your particular user model I have chosen to use @remarkablerocket's implementation instead. However, it would be really great if you could give this branch a try so we can see whether it works with your particular user model.

Thanks!

[dokterbob]

Hey @Burakk, we now have a pull request for custom user model support - but it requires more through (manual) testing. Would be great if you could lend a hand with that - would be great to be able to push out a new (poin) release today or tomorrow.

Thanks!

[sinasamavati]

@dokterbob sorry for replying too late. actually, I wasn't sure about the migration, that it would work for everyone or not, and unfortunately I've had no time to check it out.

alright, I'm gonna check out @remarkablerocket's implementation as soon as possible.

Thanks

[danielpatrickdotdev]

Sorry for not responding sooner, @dokterbob. I never really tested the solution thoroughly at the time.

From a quick investigation it appears to be working with South 0.8.2 but broken in South 0.8.3. with South 0.8.3 I'm getting the following error when trying to migrate for the first time:

django.core.exceptions.ImproperlyConfigured: AUTH_USER_MODEL refers to model 'userprofile.CustomUser' that has not been installed

[dokterbob]

Thanks for the feedback!

|django.core.exceptions.ImproperlyConfigured: AUTH_USER_MODEL refers to model 'userprofile.CustomUser' that has not been installed
Just checking: is userprofiles in INSTALLED_APPS?

[danielpatrickdotdev]

That would be embarrassing, but yes it is. Otherwise it wouldn't have worked with the other version of South.

[dokterbob]

Embarrassing stuff happens all the time, at least for me it does.

Will look into this issue tomorrow or perhaps this weekend. Hope to be able to push out a release after the weekend.

Thanks again for the feedback!

[dokterbob]

@remarkablerocket I've implemented the suggestions documented here. Would be great to get some feedback on this one.

Thanks!

[dokterbob]

Note: I've succesfully run migrations with South 0.8.3 and Django's normal user model.

[dokterbob]

There seem to be a host of issues involved, one of which is a bug in South 0.8.3.

Related:

• Error during South migration with Twitter provider pennersr/django-allauth#449
• compatibility issue of reversion (version 1.8.0) with latest version of south (version 0.8.3) etianen/django-reversion#263
• http://south.aeracode.org/ticket/1320

More references:

• http://kevindias.com/writing/django-custom-user-models-south-and-reusable-apps/
• https://gist.github.com/benjaoming/5605160
• http://stackoverflow.com/questions/15472704/trouble-migrating-reusable-django-app-models-to-use-a-custom-user-model
• fusionbox/mezzanine@a9ea147
• http://south.aeracode.org/ticket/1179

[dokterbob]

@s1n4 @remarkablerocket @Burakk After a lot of turmoil it turns out there is a bug in South 0.8.3.

I have currently updated migrations using @benjaoming's script which closely resembles kevindias' recommended practises. (Also I have experimented around a bit with lazy User' objects and such, to no avail.)

Eventually I have built in an explicit exception when South 0.8.3 is installed, recommending users to downgrade.

My question to you is as follows: should I

1. wait for South to be fixed in 0.8.4 and consequently postpone custom user model support to 0.5.2 or;
2. release 0.5.1 with this known South issue and hope not too many people have upgraded South yet?

All feedback welcome. In any case: thanks so much for thinking along, helping with testing and such.

[sinasamavati]

I think third-party issues are unrelated to a project. however, waiting for South to be fixed wouldn't be bad.

Thanks.

[jhgg]

Fixed in latest south 0.8.4.